On 27 Feb 2025, at 18:23, Adrian Moreno wrote:

> When the netlink buffer overflows and upcalls get dropped, we increase
> a coverage counter and log it but we don't have information of what
> specific packet was dropped and were it came from.
>
> This series improves upcall_monitor.py to do that.

I’ll be on PTO next week, but did you fix my comments on v2? If not I’ll review 
patches 7 and 8 when I return.

Cheers,

Eelco

> ---
> v3:
>     - Resend as some patches were missing.
>     - Automatically disable error monitoring if not supported.
>     - Fix flake8 warnings.
> v2:
>     - Address Eelco's comments.
>     - Add a retry mechanism to dp cache.
>
> Adrian Moreno (8):
>   utilities: usdt-scripts: Remove sleep in loop.
>   utilities: upcall_monitor: Monitor dropped upcalls.
>   utilities: upcall_monitor: Allow filtering on result.
>   utilities: upcall_cost: Refactor port mapping cache.
>   utilities: upcall_monitor: Print port names.
>   utilities: monitor_upcalls: Print ports from drops.
>   utilities: upcall_monitor: Add extra info to pcap.
>   utilities: usdt-scripts: Retry on dp cache miss.
>
>  utilities/automake.mk                        |   7 +-
>  utilities/usdt-scripts/dpif_op_nl_monitor.py |   2 -
>  utilities/usdt-scripts/upcall_cost.py        |  73 +----
>  utilities/usdt-scripts/upcall_monitor.py     | 324 ++++++++++++++-----
>  utilities/usdt-scripts/usdt_lib.py           | 102 ++++++
>  5 files changed, 369 insertions(+), 139 deletions(-)
>  create mode 100644 utilities/usdt-scripts/usdt_lib.py
>
> -- 
> 2.48.1
>
> _______________________________________________
> dev mailing list
> [email protected]
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to