On 3/1/25 2:52 PM, Frank Wagner wrote: > This patch fixes the cccl script to work with MSYS which now reports > itself as cygwin in MACHTYPE. Same patch was submitted to OVS. > If a older MSYS is used this patch will will not be needed. > > Signed-off-by: Frank Wagner <[email protected]> > > ---
Hi Frank, Thanks for the patch! I'd say, let's wait until the review on the OVS equivalent change is completed: https://patchwork.ozlabs.org/project/openvswitch/patch/pavp189mb245804c450eab74d69070756f5...@pavp189mb2458.eurp189.prod.outlook.com/ Thanks, Dumitru > build-aux/cccl | 24 ++++++++++++++++-------- > 1 file changed, 16 insertions(+), 8 deletions(-) > > diff --git a/build-aux/cccl b/build-aux/cccl > index e2426fb3e..855d24c6c 100644 > --- a/build-aux/cccl > +++ b/build-aux/cccl > @@ -33,14 +33,22 @@ EOF > exit $1 > } > > -case $MACHTYPE in > - *-msys) > - slash="-" > - ;; > - *) > - slash="/" > - ;; > -esac > + > + > +# Check for MSYS which now reports itself as cygwin in MACHTYPE > +if [[ -n "$MSYSTEM" ]]; then > + slash="-" > +else > + # fallback to old behavior > + case $MACHTYPE in > + *-msys) > + slash="-" > + ;; > + *) > + slash="/" > + ;; > + esac > +fi > # prog specifies the program that should be run (cl.exe or link.exe) > # We'll assume cl to start out > prog=cl _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
