On 4/3/25 2:21 PM, Dumitru Ceara wrote:
> On 4/3/25 10:26 AM, Ales Musil wrote:
>> On Mon, Mar 31, 2025 at 4:07 PM Ilya Maximets <[email protected]> wrote:
>>
>>> STT encapsulation type was deprecated in OVN 25.03 and is no longer
>>> supported in OVS since commit:
>>>
>>>   19b89416203f ("tunnels: Remove support for deprecated STT and LISP.")
>>>
>>> Remove support in OVN as well.
>>>
>>> OVS submodule is moved beyond the corresponding commit because we must
>>> have the flake8 fix for the F824 check, otherwise CI will fail.
>>>
>>> Note: This commit makes backward incompatible change in the Southbound
>>> DB schema by removing support for 'stt' from the encapsulation type
>>> column.  Users must migrate to other encapsulation types before
>>> attempting upgrade to the future OVN 25.09.  Corresponding warning is
>>> added to the NEWS file.
>>>
>>> Signed-off-by: Ilya Maximets <[email protected]>
>>> ---
> 
> Hi Ilya, Ales,
> 
>> Looks good to me, thanks.
>> Acked-by: Ales Musil <[email protected]>
>>
> 
> Thanks!  Applied to main with a minor change to the schema version:
> 
> diff --git a/ovn-ic-sb.ovsschema b/ovn-ic-sb.ovsschema
> index 0269b3b759..459c3833e8 100644
> --- a/ovn-ic-sb.ovsschema
> +++ b/ovn-ic-sb.ovsschema
> @@ -1,7 +1,7 @@
>  {
>      "name": "OVN_IC_Southbound",
> -    "version": "2.3.0",
> -    "cksum": "1259594626 7081",
> +    "version": "2.0.0",
> +    "cksum": "197748428 7081",
>      "tables": {
>          "IC_SB_Global": {
>              "columns": {
> diff --git a/ovn-sb.ovsschema b/ovn-sb.ovsschema
> index 77c7d95b91..d7cfeaa8fb 100644
> --- a/ovn-sb.ovsschema
> +++ b/ovn-sb.ovsschema
> @@ -1,7 +1,7 @@
>  {
>      "name": "OVN_Southbound",
> -    "version": "21.41.0",
> -    "cksum": "38144040 34712",
> +    "version": "21.0.0",
> +    "cksum": "4028932437 34711",
>      "tables": {
>          "SB_Global": {
>              "columns": {
> 
> According to ovsdb.7.rst we need to: "Whenever we change the database
> schema in a non-backward compatible way (e.g. when we delete a column or
> a table), we increment <x> and set <y> and <z> to 0.".

Oops.  Yeah, I increased the x, but somehow missed re-setting the y.
Thanks!

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to