While creating passive TCP connections the library stores part of the
connection method as a bind path regardless of it being a path. And
then it may attempt to unlink it on close:
fatal-signal | WARN | could not unlink "27.0.0.1:58866"
(No such file or directory)
Unlinking only makes sense for unix sockets, not TCP, so the variable
should only be initialized for "punix" case. It's not a big problem
since those files are unlikely to exist, but it generates strange
warnings in the logs.
Fixes: af3582371193 ("python: Add TCP passive-mode to IDL.")
Signed-off-by: Ilya Maximets <[email protected]>
---
python/ovs/stream.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/python/ovs/stream.py b/python/ovs/stream.py
index 2282905ed..4b4b07d03 100644
--- a/python/ovs/stream.py
+++ b/python/ovs/stream.py
@@ -585,9 +585,9 @@ class PassiveStream(object):
if not PassiveStream.is_valid_name(name):
return errno.EAFNOSUPPORT, None
- bind_path = name[6:]
+ bind_path = None
if name.startswith("punix:"):
- bind_path = ovs.util.abs_file_name(ovs.dirs.RUNDIR, bind_path)
+ bind_path = ovs.util.abs_file_name(ovs.dirs.RUNDIR, name[6:])
if sys.platform != 'win32':
error, sock = ovs.socket_util.make_unix_socket(
socket.SOCK_STREAM, True, bind_path, None)
--
2.47.0
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
