Hi Mark, On 3/4/25 7:39 PM, Mark Michelson wrote: > Note that this series claims to have 6 patches, but there are actually > only 3. This is because my branch has 6 commits on it, but I only put > the first three up for review. If a v2 is required, I'll ensure that the > numbering for the patches is accurate. >
The downside of this is that it confuses ovsrobot and therefore it didn't trigger any CI runs with this series applied. > On 3/4/25 12:19, Mark Michelson wrote: >> This patch series seeks to refactor how northbound datapath types are >> synced with southbound Datapath_Bindings. >> >> Currently, there are two types of logical datapaths in OVN, >> Logical_Switch and Logical_Router. The en-northd node is responsible for >> syncing these logical datapaths with southbound datapath bindings. >> >> An upcoming feature (composable services) seeks to add new types of >> logical datapaths in the northbound database. However, these new logical >> datapath types have little overlap with existing Logical_Routers >> or Logical_Switches. Their processing is much more narrow and simple, >> too. We're faced with two choices: >> >> 1) Expand the struct ovn_datapath type in northd to also understand >> composable service datapath types. Expand build_datapaths() in northd.c >> to handle these new composable service logical datapaths. Add logical >> flow processing for composable services to northd.c. >> >> 2) Perform datapath syncing prior to en-northd running. Composable >> services can then create their logical flows in separate incremental >> nodes outside of en-northd. >> >> This series opts for option 2. >> >> The goal was to have this series encompass both southbound >> Datapath_Binding syncing and southbound Port_Binding syncing. However, I >> have had to start over from scratch too many times on the Port_Binding >> syncing, and rebasing this branch is a pain. Therefore, the >> Datapath_Binding syncing change is here on its own. >> >> Mark Michelson (6): >> en-global-config: Cache vxlan mode and max tunnel key. >> northd: Remove lr_list from en_northd data. >> northd: Refactor datapath syncing. >> ovn-nb: Add Service Chain to schema. >> ovn-nb: Add NAT_Service table to schema. >> northd: Set options:port in Port_Binding in pb_sync node. >> Regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
