> The 'garp_rarp' local variable is only used in that function and points
> to memory that is only modified under the lock that's held when the
> function is called.
>
> Spotted during code review.
>
> Fixes: 24f1af2c62c7 ("ovn: Support for GARP for NAT IPs via localnet")
> Signed-off-by: Dumitru Ceara <[email protected]>
Acked-by: Lorenzo Bianconi <[email protected]>
> ---
> controller/pinctrl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/controller/pinctrl.c b/controller/pinctrl.c
> index 0647f053d2..6377fdd44a 100644
> --- a/controller/pinctrl.c
> +++ b/controller/pinctrl.c
> @@ -5051,7 +5051,7 @@ send_garp_rarp_update(struct ovsdb_idl_txn
> *ovnsb_idl_txn,
> long long int garp_max_timeout,
> bool garp_continuous)
> {
> - volatile struct garp_rarp_data *garp_rarp = NULL;
> + struct garp_rarp_data *garp_rarp = NULL;
>
> /* Skip localports as they don't need to be announced */
> if (!strcmp(binding_rec->type, "localport")) {
> --
> 2.49.0
>
> _______________________________________________
> dev mailing list
> [email protected]
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
