Dmitry Porokh via dev <ovs-dev@openvswitch.org> writes: > Hi Ilya,
Hi Dmitry, Please reply inline to the list rather than top posting. Top posts are generally harder to follow for discussion. > I apologize for inconvenience. I would love to run all possible tests > before sending patches (and I did as contribution guide suggested. > https://github.com/openvswitch/ovs/blob/main/Documentation/internals/contributing/submitting-patches.rst#id1, > but apparently recommended make distcheck doesn't include coding style > checks). Note that the document also has the following:: If your code is non-datapath code, you may use the utilities/checkpatch.py utility as a quick check for certain commonly occurring mistakes (improper leading/trailing whitespace, missing signoffs, some improper formatted patch files). And even:: If you are using GitHub, then you may utilize the GitHub Actions CI build systems. They will run some of the above tests automatically when you push changes to your repository. However, maybe it seems like that document could be refactored a bit, or even have a checklist type section to follow? Since you are going bootstrapping through the process of contributing, a good follow up might be to take what you learn here and update it to help the next person. WDYT? > Thanks, > Dmitry > > ________________________________________ > From: Ilya Maximets <i.maxim...@ovn.org> > Sent: Tuesday, May 13, 2025 11:10 AM > To: Dmitry Porokh <dpor...@nvidia.com>; d...@openvswitch.org > <d...@openvswitch.org> > Cc: i.maxim...@ovn.org <i.maxim...@ovn.org>; Aaron Conole <acon...@redhat.com> > Subject: Re: [ovs-dev] [PATCH v3] ovsdb: Use static json objects to > reduce memory allocator usage. > > External email: Use caution opening links or attachments > > > On 5/13/25 7:23 PM, Dmitry Porokh via dev wrote: >> The idea of this change is to reduce memory allocations/deallocations >> for constant json objects like "uuid", "named_uuid", "map", etc. >> >> Signed-off-by: Dmitry Porokh <dpor...@nvidia.com> >> --- >> Notes: >> v2/v3: >> - style & max line length fixes > > Please ensure that all patches are tested locally before submission. This > includes running checkpatch as well as the test suite. Both GitHub Actions > and Cirrus CI are available for free on personal forks, so please take > advantage of these tools before sending changes upstream, if you don't want > to run tests manually. > > And wait for human feedback for at least 24 hours or, more realistically, > a few days before sending new revisions. > > Shooting out patches without testing them only wastes resources of the shared > CI infrastructure and everyone's time. > > Best regards, Ilya Maximets. > _______________________________________________ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
