On 15 May 2025, at 5:26, yangyang92--- via dev wrote:
> From: yangyang92 <[email protected]> > > Ovsdb-server should not care about guest events, so set it to true by > default. > > Signed-off-by: lirongqing <[email protected]> > Signed-off-by: yangyang92 <[email protected]> Hi, Thanks for the patch. The change below looks good to me, but I haven’t used this part of the infrastructure myself, so I hope others will also review it. A few notes from a patch formatting perspective: - You don’t need to include a cover letter when sending a single (standalone) patch. A cover letter is only needed when sending a patch series. - If you want to explain why this patch is needed, you can include that explanation directly in the patch commit message. This is better than putting it in a cover letter, because the cover letter is not stored in the git history. - The patch currently has two Signed-off-by tags. Usually, only the author needs to sign off. If lirongqing helped write the patch, you should also add a ‘Co-authored-by: lirongqing <[email protected]>’ tag. Cheers, Eelco > --- > lib/perf-counter.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/perf-counter.c b/lib/perf-counter.c > index 022e0d2cd..1622ba851 100644 > --- a/lib/perf-counter.c > +++ b/lib/perf-counter.c > @@ -71,6 +71,7 @@ perf_event_setup(void) > pe.disabled = 1; > pe.exclude_kernel = 1; > pe.exclude_hv = 1; > + pe.exclude_guest = 1; > > fd__ = perf_event_open(&pe, 0, -1, -1, 0); > if (fd__ > 0) { > -- > 2.49.0 > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
