Bleep bloop. Greetings Aleksandr Smirnov, I am a robot and I have tried out your patch. Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Aleksandr Smirnov <[email protected]> needs to sign off. WARNING: Line is 80 characters long (recommended limit is 79) #77 FILE: northd/en-lr-nat.c:153: hmapx_add(&data->trk_data.mod_l3dgw, ent->l3dgw_port->peer->od); WARNING: Line is 80 characters long (recommended limit is 79) #94 FILE: northd/en-lr-nat.c:170: hmapx_add(&data->trk_data.mod_l3dgw, ent->l3dgw_port->peer->od); WARNING: Line is 92 characters long (recommended limit is 79) #331 FILE: northd/northd.c:9700: ds_put_format(&match, "(arp.op == 1 || arp.op == 2) && inport == %s", op->json_key); ERROR: Inappropriate spacing in pointer declaration #403 FILE: northd/northd.c:17872: build_lswitch_arp_chassis_resident((struct ovn_datapath*) od, lflows, WARNING: ovn-nbctl return should be checked Consider adding check or check_uuid in front. #486 FILE: tests/ovn.at:43512: ovn-nbctl lr-add lr1 WARNING: ovn-nbctl return should be checked Consider adding check or check_uuid in front. #487 FILE: tests/ovn.at:43513: ovn-nbctl lrp-add lr1 down_link f0:00:00:00:00:f1 192.168.1.1/24 WARNING: ovn-nbctl return should be checked Consider adding check or check_uuid in front. #489 FILE: tests/ovn.at:43515: ovn-nbctl ls-add ls1 WARNING: ovn-nbctl return should be checked Consider adding check or check_uuid in front. #490 FILE: tests/ovn.at:43516: ovn-nbctl lsp-add ls1 up_link WARNING: ovn-nbctl return should be checked Consider adding check or check_uuid in front. #491 FILE: tests/ovn.at:43517: ovn-nbctl lsp-add ls1 down_vif1 WARNING: ovn-nbctl return should be checked Consider adding check or check_uuid in front. #492 FILE: tests/ovn.at:43518: ovn-nbctl lsp-add ls1 down_vif2 WARNING: ovn-nbctl return should be checked Consider adding check or check_uuid in front. #493 FILE: tests/ovn.at:43519: ovn-nbctl lsp-add ls1 down_ext WARNING: ovn-nbctl return should be checked Consider adding check or check_uuid in front. #498 FILE: tests/ovn.at:43524: ovn-nbctl set Logical_Switch_Port up_link + type=router + options:router-port=down_link + addresses=router WARNING: ovn-nbctl return should be checked Consider adding check or check_uuid in front. #500 FILE: tests/ovn.at:43526: ovn-nbctl lsp-set-addresses down_vif1 'f0:00:00:00:00:01 192.168.1.101' WARNING: ovn-nbctl return should be checked Consider adding check or check_uuid in front. #501 FILE: tests/ovn.at:43527: ovn-nbctl lsp-set-addresses down_vif2 'f0:00:00:00:00:02 192.168.1.102' WARNING: ovn-nbctl return should be checked Consider adding check or check_uuid in front. #503 FILE: tests/ovn.at:43529: ovn-nbctl lsp-set-type down_ext localnet WARNING: ovn-nbctl return should be checked Consider adding check or check_uuid in front. #504 FILE: tests/ovn.at:43530: ovn-nbctl lsp-set-options down_ext network_name=physnet1 WARNING: ovn-nbctl return should be checked Consider adding check or check_uuid in front. #505 FILE: tests/ovn.at:43531: ovn-nbctl lrp-set-gateway-chassis down_link hv1 WARNING: ovn-nbctl return should be checked Consider adding check or check_uuid in front. #560 FILE: tests/ovn.at:43586: ovn-nbctl lrp-set-gateway-chassis down_link hv2 WARNING: ovn-nbctl return should be checked Consider adding check or check_uuid in front. #594 FILE: tests/ovn.at:43620: ovn-nbctl --wait=hv lsp-set-type down_ext l2gateway WARNING: ovn-nbctl return should be checked Consider adding check or check_uuid in front. #617 FILE: tests/ovn.at:43643: ovn-nbctl --wait=hv lsp-set-type down_ext localnet Lines checked: 625, Warnings: 19, Errors: 2 Please check this out. If you feel there has been an error, please email [email protected] Thanks, 0-day Robot _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
