On 5/20/25 3:22 PM, Ilya Maximets wrote:
> On 5/20/25 2:27 PM, Dumitru Ceara wrote:
>> On 5/19/25 9:43 PM, Ilya Maximets wrote:
>>> On 5/8/25 9:23 PM, Alexandra Rukomoinikova wrote:
>>>> Added checksum which is calculated for pipeline stages.
>>>> Also, the tool calculate-pipeline-cksum is introduced. This tool
>>>> calculates the cksum of a pipeline stages.
>>>>
>>>> Signed-off-by: Alexandra Rukomoinikova <[email protected]>
>>>> ---
>>
>> Hi Alexandra, Ilya,
>>
>> Thanks for the patch and for the review!
>>
>>>> v4 --> v5: addressed Ilya comments.
>>>>       rebased
>>>> ---
>>>>  Makefile.am                        | 10 ++++++++++
>>>>  build-aux/automake.mk              |  2 ++
>>>>  build-aux/calculate-pipeline-cksum | 10 ++++++++++
>>>>  build-aux/cksum-pipeline-check     | 19 +++++++++++++++++++
>>>>  lib/ovn-util.c                     |  6 +++++-
>>>>  5 files changed, 46 insertions(+), 1 deletion(-)
>>>>  create mode 100755 build-aux/calculate-pipeline-cksum
>>>>  create mode 100755 build-aux/cksum-pipeline-check
>>>
>>> Thanks, Alexandra, for v5!  I left a few nits below that maybe maintainers
>>> can address while applying.  The patch seems to work fine otherwise.
>>>
>>> Acked-by: Ilya Maximets <[email protected]>
>>>
>>
>> I folded in the minor changes Ilya requested and applied this patch to main.
> 
> Thanks!  Should this also be backported down to e.g. 24.03?
> So we do not forget to update internal version in backports.
> This will make backporting potential pipeline changes a bit
> more difficult.  But that's exactly the point.
> 
> WDYT?
> 

Hi Ilya,

OK, that makes sense.  I applied the patch to 25.03, 24.09 and 24.03 too
(with the required checksum changes).

Regards,
Dumitru

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to