On 20 May 2025, at 4:47, yangyang92--- via dev wrote:
> From: yangyang92 <[email protected]>
>
> Ovsdb-server should not care about guest events, so set it to true by
> default.
Hi,
Thanks for the patch!
First off, could you let us know your full names? That way we can properly
credit you in AUTHORS.rst instead of using just "lirongqing" and "yangyang92."
You might also want to set up your email client or server to include your full
name by default, like:
Full Name <[email protected]>
Second, I think the commit message could be a bit clearer, something closer to
what you wrote in your original cover letter would work:
This patch sets exclude_guest to true by default in perf-counter.
Since ovsdb-server typically does not need guest context events,
this change avoids collecting unnecessary data and improves profiling
accuracy on the host.
Lastly, you'll need to include the sign-off tag for both authors. It should
look like this:
Co-authored-by: Real Name <[email protected]>
Signed-off-by: Real Name <[email protected]>
Signed-off-by: Real Name <[email protected]>
Thanks again! If you send out the v4, you can send it out as a single email,
the version history can go below the --- sign. See example below.
Cheers,
Eelco
> Co-authored-by: lirongqing <[email protected]>
> Signed-off-by: yangyang92 <[email protected]>
> ---
Changes in v3:
- Add missing period at the end of the commit message.
Changes in v2:
- Removed extra Signed-off-by tag
- Improved commit message wording
---
> lib/perf-counter.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/perf-counter.c b/lib/perf-counter.c
> index 022e0d2cd..1622ba851 100644
> --- a/lib/perf-counter.c
> +++ b/lib/perf-counter.c
> @@ -71,6 +71,7 @@ perf_event_setup(void)
> pe.disabled = 1;
> pe.exclude_kernel = 1;
> pe.exclude_hv = 1;
> + pe.exclude_guest = 1;
>
> fd__ = perf_event_open(&pe, 0, -1, -1, 0);
> if (fd__ > 0) {
> --
> 2.49.0
>
> _______________________________________________
> dev mailing list
> [email protected]
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
