On 26 May 2025, at 21:00, Mike Pattrick via dev wrote:
> Previously ct_orig_tuple information was removed from packet metadata
> initialization with the theory that it would always be set correctly if
> ct_state was set.
>
> However, there are some cases where ct_state is set without setting this
> value in ipf. This leads to an uninitialized value being used in
> miniflow_extract. This was identified through ubsan:
>
> lib/flow.c:900:35: runtime error: load of value 190, which is not a
> valid value for type 'bool'
> lib/flow.c:900 miniflow_extract
> lib/dpif-netdev.c:8317 dfc_processing
> lib/dpif-netdev.c:8598 dp_netdev_input__
> lib/dpif-netdev.c:8650 dp_netdev_recirculate
> lib/dpif-netdev.c:9045 dp_execute_cb
> lib/odp-execute.c:890 odp_actions_impl_set
> lib/dpif-netdev.c:9231 dp_netdev_execute_actions
> lib/dpif-netdev.c:8419 handle_packet_upcall
> lib/dpif-netdev.c:8515 fast_path_processing
> lib/dpif-netdev.c:8604 dp_netdev_input__
> lib/dpif-netdev.c:8642 dp_netdev_input
> lib/dpif-netdev.c:5423 dp_netdev_process_rxq_port
> lib/dpif-netdev.c:6758 dpif_netdev_run
>
> SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior lib/flow.c:900:35
>
> Reported-at: https://issues.redhat.com/browse/FDP-1433
> Fixes: af697f26b51b ("packets: Do not initialize ct_orig_tuple.")
> Signed-off-by: Mike Pattrick <m...@redhat.com>
Change looks good to me.
Acked-by: Eelco Chaudron <echau...@redhat.com>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
