On Mon, 30 Jun 2025 11:35:40 +0200 David Marchand via dev <[email protected]> wrote:
Hi, I've reviewed the current code in the repository, the commit indicated below and also created the RPM with DPDK enabled using: make rpm-fedora RPMBUILD_OPT="--with dpdk" Nice to see that macro going away. Acked-by: Flavio Leitner <[email protected]> > This macro is a left over from previous implementation. > > Fixes: 3337e6d91c5b ("userspace: Enable L4 checksum offloading by > default.") Signed-off-by: David Marchand <[email protected]> > --- > lib/netdev-dpdk.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > index d33e39c71c..17b4d66779 100644 > --- a/lib/netdev-dpdk.c > +++ b/lib/netdev-dpdk.c > @@ -159,17 +159,6 @@ typedef uint16_t dpdk_port_t; > > #define IF_NAME_SZ (PATH_MAX > IFNAMSIZ ? PATH_MAX : IFNAMSIZ) > > -/* List of required flags advertised by the hardware that will be > used > - * if TSO is enabled. Ideally this should include > - * RTE_ETH_TX_OFFLOAD_SCTP_CKSUM. However, very few drivers support > that > - * at the moment and SCTP is not a widely used protocol like TCP and > UDP, > - * so it's optional. */ > -#define DPDK_TX_TSO_OFFLOAD_FLAGS (RTE_ETH_TX_OFFLOAD_TCP_TSO > \ > - | RTE_ETH_TX_OFFLOAD_TCP_CKSUM > \ > - | RTE_ETH_TX_OFFLOAD_UDP_CKSUM > \ > - | RTE_ETH_TX_OFFLOAD_IPV4_CKSUM) > - > - > static const struct rte_eth_conf port_conf = { > .rxmode = { > .offloads = 0, _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
