On 06.08.2025 22:50, Mark Michelson wrote:
The above line sets en_lflow to have no input handler for en_ic_learned_svcs. 
If you had an input handler, this is where you could use the lflow_ref to only 
recompute the lflows associated with the en_ic_learned_svcs. Since the input 
handler is NULL, there is no reason to have an lflow_ref at all. You can simply 
pass NULL as the lflow_ref argument.

The alternative would be to define an input handler for en_ic_learned_svcs that 
makes use of the lflow_ref. Since you are using a single lflow_ref for all 
en_ic_learned_svcs, it is possible you can install the same lflow on multiple 
datapaths. If you want to see an example of an input handler that also does 
this, see lflow_multicast_igmp_handler() in northd/en-lflow.c. This would fit 
well as part of patch 4, where you add the code that adds logical flows for 
IC-learned service monitors.

Hi Mark, thanks for the review. Thanks for explaining how lflow_ref works, I 
wasn't aware of it) Thanks) I'll add the handler)

--
regards,
Alexandra.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to