[ovs-dev] [PATCH] net: openvswitch: Use for_each_cpu_from() where appropriate

[Yury Norov]

From: Yury Norov (NVIDIA) <yury.no...@gmail.com>

Openvswitch opencodes for_each_cpu_from(). Fix it and drop some
housekeeping code.

Signed-off-by: Yury Norov (NVIDIA) <yury.no...@gmail.com>
---
 net/openvswitch/flow.c       | 14 ++++++--------
 net/openvswitch/flow_table.c |  8 ++++----
 2 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c
index b80bd3a90773..b464ab120731 100644
--- a/net/openvswitch/flow.c
+++ b/net/openvswitch/flow.c
@@ -129,15 +129,14 @@ void ovs_flow_stats_get(const struct sw_flow *flow,
                        struct ovs_flow_stats *ovs_stats,
                        unsigned long *used, __be16 *tcp_flags)
 {
-       int cpu;
+       /* CPU 0 is always considered */
+       unsigned int cpu = 1;
 
        *used = 0;
        *tcp_flags = 0;
        memset(ovs_stats, 0, sizeof(*ovs_stats));
 
-       /* We open code this to make sure cpu 0 is always considered */
-       for (cpu = 0; cpu < nr_cpu_ids;
-            cpu = cpumask_next(cpu, flow->cpu_used_mask)) {
+       for_each_cpu_from(cpu, flow->cpu_used_mask) {
                struct sw_flow_stats *stats = 
rcu_dereference_ovsl(flow->stats[cpu]);
 
                if (stats) {
@@ -158,11 +157,10 @@ void ovs_flow_stats_get(const struct sw_flow *flow,
 /* Called with ovs_mutex. */
 void ovs_flow_stats_clear(struct sw_flow *flow)
 {
-       int cpu;
+       /* CPU 0 is always considered */
+       unsigned int cpu = 1;
 
-       /* We open code this to make sure cpu 0 is always considered */
-       for (cpu = 0; cpu < nr_cpu_ids;
-            cpu = cpumask_next(cpu, flow->cpu_used_mask)) {
+       for_each_cpu_from(cpu, flow->cpu_used_mask) {
                struct sw_flow_stats *stats = 
ovsl_dereference(flow->stats[cpu]);
 
                if (stats) {
diff --git a/net/openvswitch/flow_table.c b/net/openvswitch/flow_table.c
index d108ae0bd0ee..0a97ea08457a 100644
--- a/net/openvswitch/flow_table.c
+++ b/net/openvswitch/flow_table.c
@@ -107,16 +107,16 @@ int ovs_flow_tbl_count(const struct flow_table *table)
 
 static void flow_free(struct sw_flow *flow)
 {
-       int cpu;
+       /* CPU 0 is always considered */
+       unsigned int cpu = 1;
 
        if (ovs_identifier_is_key(&flow->id))
                kfree(flow->id.unmasked_key);
        if (flow->sf_acts)
                ovs_nla_free_flow_actions((struct sw_flow_actions __force *)
                                          flow->sf_acts);
-       /* We open code this to make sure cpu 0 is always considered */
-       for (cpu = 0; cpu < nr_cpu_ids;
-            cpu = cpumask_next(cpu, flow->cpu_used_mask)) {
+
+       for_each_cpu_from(cpu, flow->cpu_used_mask) {
                if (flow->stats[cpu])
                        kmem_cache_free(flow_stats_cache,
                                        (struct sw_flow_stats __force 
*)flow->stats[cpu]);
-- 
2.43.0

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev