References: <[email protected]>
Bleep bloop. Greetings Sragdhara Datta Chaudhuri, I am a robot and I have
tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 596 characters long (recommended limit is 79)
#41 FILE: utilities/ovn-nbctl.8.xml:402:
<dt>[<code>--type=</code>{<code>switch</code> |
<code>port-group</code>}] [<code>--log</code>]
[<code>--meter=</code><var>meter</var>]
[<code>--severity=</code><var>severity</var>]
[<code>--name=</code><var>name</var>] [<code>--label=</code><var>label</var>]
[<code>--sample-new=</code><var>sample</var>]
[<code>--sample-est=</code><var>sample</var>] [<code>--may-exist</code>]
[<code>--apply-after-lb</code>] [<code>--tier</code>] <code>acl-add</code>
<var>entity</var> <var>direction</var> <var>priority</var> <var>match</var>
<var>verdict</var> [<var>network-function-group</var>]</dt>
WARNING: Line is 126 characters long (recommended limit is 79)
#52 FILE: utilities/ovn-nbctl.8.xml:478:
<dt>[<code>--may-exist</code>] <code>network-function-add</code>
<var>nf</var> <var>inport</var> <var>outport</var></dt>
WARNING: Line is 89 characters long (recommended limit is 79)
#72 FILE: utilities/ovn-nbctl.8.xml:498:
<dt>[<code>--if-exists</code>] <code>network-function-del</code>
<var>nf</var></dt>
WARNING: Line is 145 characters long (recommended limit is 79)
#88 FILE: utilities/ovn-nbctl.8.xml:514:
<dt>[<code>--may-exist</code>] <code>network-function-group-add</code>
<var>nfg</var> <var>id</var> <var>mode</var> [<var>nf</var>]...</dt>
WARNING: Line is 96 characters long (recommended limit is 79)
#112 FILE: utilities/ovn-nbctl.8.xml:538:
<dt>[<code>--if-exists</code>] <code>network-function-group-del</code>
<var>nfg</var></dt>
WARNING: Line is 127 characters long (recommended limit is 79)
#128 FILE: utilities/ovn-nbctl.8.xml:554:
<dt>[<code>--may-exist</code>]
<code>network-function-group-add-network-function</code> <var>nfg</var>
<var>nf</var></dt>
WARNING: Line is 100 characters long (recommended limit is 79)
#139 FILE: utilities/ovn-nbctl.8.xml:565:
<dt><code>network-function-group-del-network-function</code>
<var>nfg</var> <var>nf</var></dt>
WARNING: Line is 90 characters long (recommended limit is 79)
WARNING: Line lacks whitespace around operator
#163 FILE: utilities/ovn-nbctl.c:286:
acl-add {SWITCH | PORTGROUP} DIRECTION PRIORITY MATCH ACTION
[NETWORK-FUNCTION-GROUP]\n\
WARNING: Line is 84 characters long (recommended limit is 79)
WARNING: Line lacks whitespace around operator
#172 FILE: utilities/ovn-nbctl.c:377:
network-function-group-add NETWORK-FUNCTION-GROUP ID MODE
[NETWORK-FUNCTION]...\n\
WARNING: Line lacks whitespace around operator
#173 FILE: utilities/ovn-nbctl.c:378:
create a network-function-group\n\
WARNING: Line lacks whitespace around operator
#174 FILE: utilities/ovn-nbctl.c:379:
network-function-group-del NETWORK-FUNCTION-GROUP\n\
WARNING: Line lacks whitespace around operator
#175 FILE: utilities/ovn-nbctl.c:380:
delete a network-function-group\n\
WARNING: Line lacks whitespace around operator
#176 FILE: utilities/ovn-nbctl.c:381:
network-function-group-list print all network-function-groups\n\
WARNING: Line is 88 characters long (recommended limit is 79)
WARNING: Line lacks whitespace around operator
#177 FILE: utilities/ovn-nbctl.c:382:
network-function-group-add-network-function NETWORK-FUNCTION-GROUP
NETWORK-FUNCTION\n\
WARNING: Line lacks whitespace around operator
#178 FILE: utilities/ovn-nbctl.c:383:
add a network-function to a\n\
WARNING: Line lacks whitespace around operator
#179 FILE: utilities/ovn-nbctl.c:384:
network-function-group\n\
WARNING: Line is 88 characters long (recommended limit is 79)
WARNING: Line lacks whitespace around operator
#180 FILE: utilities/ovn-nbctl.c:385:
network-function-group-del-network-function NETWORK-FUNCTION-GROUP
NETWORK-FUNCTION\n\
WARNING: Line lacks whitespace around operator
#181 FILE: utilities/ovn-nbctl.c:386:
delete a network-function from a\n\
WARNING: Line lacks whitespace around operator
#182 FILE: utilities/ovn-nbctl.c:387:
network-function-group\n\
WARNING: Line lacks whitespace around operator
#185 FILE: utilities/ovn-nbctl.c:390:
network-function-add NETWORK-FUNCTION PORT-IN PORT-OUT\n\
WARNING: Line lacks whitespace around operator
#186 FILE: utilities/ovn-nbctl.c:391:
create a network-function\n\
WARNING: Line lacks whitespace around operator
#187 FILE: utilities/ovn-nbctl.c:392:
network-function-del NETWORK-FUNCTION delete a network-function\n\
WARNING: Line lacks whitespace around operator
#188 FILE: utilities/ovn-nbctl.c:393:
network-function-list print all network-functions\n\
WARNING: Line is 86 characters long (recommended limit is 79)
#699 FILE: utilities/ovn-nbctl.c:8748:
"{SWITCH | PORTGROUP} DIRECTION PRIORITY MATCH ACTION
[NETWORK-FUNCTION-GROUP]",
Lines checked: 746, Warnings: 28, Errors: 0
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
