On 8/21/25 5:08 PM, David Marchand wrote: > On Tue, Jul 8, 2025 at 8:24 PM Ilya Maximets <[email protected]> wrote: >>> diff --git a/tests/system-interface.at b/tests/system-interface.at >>> index cb0835ad6b..15c4a0e2e1 100644 >>> --- a/tests/system-interface.at >>> +++ b/tests/system-interface.at >>> @@ -207,5 +207,17 @@ AT_CHECK([ovs-vsctl get interface tap0 link_speed], >>> [0], [dnl >>> 50000000000 >>> ]) >>> >>> +AT_CHECK([ovs-vsctl get interface tap0 duplex], [0], [dnl >>> +full >>> +]) >> >> May be worth setting the duplex to full before checking. In case the >> default value ever changes. > > This is already done a few lines before. > origin/main:tests/system-interface.at:191:AT_CHECK([ethtool -s tap0 > speed 50000 duplex full])
Indeed. Missed that. Thanks! > > >>> + >>> +AT_CHECK([ip link set dev tap0 down]) >>> +AT_CHECK([ethtool -s tap0 duplex half]) >>> +AT_CHECK([ip link set dev tap0 up]) >>> + >>> +AT_CHECK([ovs-vsctl get interface tap0 duplex], [0], [dnl >>> +half >>> +]) >>> + >>> OVS_TRAFFIC_VSWITCHD_STOP >>> AT_CLEANUP > > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
