> -----Original Message-----
> From: David Marchand [mailto:david.march...@redhat.com]
> Sent: Friday, August 29, 2025 5:37 PM
> To: Wangyunjian <wangyunj...@huawei.com>
> Cc: d...@openvswitch.org; el...@nvidia.com; Lilijun (Jerry)
> <jerry.lili...@huawei.com>; i.maxim...@ovn.org
> Subject: Re: [ovs-dev] [PATCH] netdev-offload-dpdk: Fix memory leak on error
> path in parse_flow_match().
>
> On Fri, 29 Aug 2025 at 04:22, Yunjian Wang via dev
> <ovs-dev@openvswitch.org> wrote:
> >
> > The error paths should release any allocated resources.
> >
> > Found by Coverity.
> >
> > Fixes: c1a5d0e2b573 ("netdev-offload-dpdk: Support IPv4 fragmentation
> types.")
> > Signed-off-by: Yunjian Wang <wangyunj...@huawei.com>
> > ---
> > lib/netdev-offload-dpdk.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
> > index 6ca271489..07f60106c 100644
> > --- a/lib/netdev-offload-dpdk.c
> > +++ b/lib/netdev-offload-dpdk.c
> > @@ -1526,6 +1526,8 @@ parse_flow_match(struct netdev *netdev,
> > } else {
> > VLOG_WARN_RL(&rl, "Unknown IPv4 frag
> (0x%x/0x%x)",
> > match->flow.nw_frag,
> match->wc.masks.nw_frag);
> > + free(spec);
> > + free(mask);
> > return -1;
> > }
> > consumed_masks->nw_frag = 0;
> > @@ -1609,6 +1611,8 @@ parse_flow_match(struct netdev *netdev,
> > } else {
> > VLOG_WARN_RL(&rl, "Unknown IPv6 frag
> (0x%x/0x%x)",
> > match->flow.nw_frag,
> match->wc.masks.nw_frag);
> > + free(frag_spec);
> > + free(frag_mask);
> > return -1;
> > }
> >
>
> Maybe update the commit title as flagged by checkpatch (for example
> "netdev-offload-dpdk: Fix memory leak for matching fragments").
Thanks for your suggestion, will include them in v2.
>
> Otherwise the fix lgtm.
> Reviewed-by: David Marchand <david.march...@redhat.com>
>
>
> --
> David Marchand
>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
