References: <[email protected]>
Bleep bloop. Greetings Renata Saiakhova, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject, '<area>: <summary>', is over 70 characters, i.e., 82.
WARNING: The subject summary should end with a dot.
Subject: netdev-dpdk, vswitchd: Support configuring Speed/Duplex/Autoneg on
DPDK interfaces
WARNING: Line is 88 characters long (recommended limit is 79)
#151 FILE: lib/netdev-dpdk.c:1198:
netdev_dpdk_convert_link_speeds(int speed_mbps, dpdk_link_duplex_t duplex, bool
autoneg)
WARNING: Line is 89 characters long (recommended limit is 79)
WARNING: Line has trailing whitespace
#247 FILE: lib/netdev-dpdk.c:1294:
VLOG_WARN("Unsupported link speed %d Mbps, falling back to
autonegotiation",
ERROR: C99 style comment
#322 FILE: lib/netdev-dpdk.c:2537:
// Autoneg ON: speed/duplex should not be forced.
ERROR: C99 style comment
#325 FILE: lib/netdev-dpdk.c:2540:
// Autoneg OFF: must set valid speed/duplex.
WARNING: Line is 83 characters long (recommended limit is 79)
#338 FILE: lib/netdev-dpdk.c:2553:
dpdk_set_link_config(struct netdev_dpdk *dev, const struct smap *args, char
**errp)
WARNING: Line is 97 characters long (recommended limit is 79)
#347 FILE: lib/netdev-dpdk.c:2562:
int requested_duplex = duplex_str && !strcmp(duplex_str, "half") ?
HALF_DUPLEX : FULL_DUPLEX;
WARNING: Line is 105 characters long (recommended limit is 79)
#349 FILE: lib/netdev-dpdk.c:2564:
VLOG_INFO("dpdk_set_link_config: Requested DPDK link configuration:
speed=%d, autoneg=%s, duplex=%s",
ERROR: C99 style comment
#354 FILE: lib/netdev-dpdk.c:2569:
// Sanity check
WARNING: Line is 90 characters long (recommended limit is 79)
#355 FILE: lib/netdev-dpdk.c:2570:
if (!is_valid_link_combo(requested_autoneg, requested_link_speed,
requested_duplex)) {
WARNING: Line is 95 characters long (recommended limit is 79)
#356 FILE: lib/netdev-dpdk.c:2571:
VLOG_WARN_BUF(errp, "Invalid DPDK link configuration: autoneg=%s,
speed=%d, duplex=%s",
ERROR: C99 style comment
#360 FILE: lib/netdev-dpdk.c:2575:
// fallback to autoneg true
WARNING: Line is 122 characters long (recommended limit is 79)
#380 FILE: lib/netdev-dpdk.c:2595:
VLOG_INFO("dpdk_set_link_config: Before reconfigure: Link configuration
changed: speed=%d, autoneg=%s, duplex=%s",
WARNING: Line is 120 characters long (recommended limit is 79)
#404 FILE: lib/netdev-dpdk.c:6489:
VLOG_DBG("netdev_dpdk_reconfigure: Before reconfigure: Link configuration
changed: speed=%d, autoneg=%s, duplex=%s",
WARNING: Line is 100 characters long (recommended limit is 79)
#434 FILE: lib/netdev-dpdk.c:6571:
VLOG_DBG("netdev_dpdk_reconfigure: Applied link configuration: speed=%d,
autoneg=%s, duplex=%s",
WARNING: Line is 93 characters long (recommended limit is 79)
#456 FILE: vswitchd/vswitch.xml:3594:
Specifies the fixed link speed in Mbps for this DPDK interface (e.g.,
1000, 10000).
WARNING: Line is 92 characters long (recommended limit is 79)
#463 FILE: vswitchd/vswitch.xml:3601:
Set to <code>true</code> to enable autonegotiation,
<code>false</code> to disable.
WARNING: Line is 108 characters long (recommended limit is 79)
#468 FILE: vswitchd/vswitch.xml:3606:
<column name="options" key="dpdk-duplex" type='{"type": "string", "enum":
["set", ["full", "half"]]}'>
WARNING: Line is 117 characters long (recommended limit is 79)
#470 FILE: vswitchd/vswitch.xml:3608:
Specifies the duplex mode for this DPDK interface. Valid values are
<code>full</code> or <code>half</code>.
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
