On 3 Sep 2025, at 23:26, Ilya Maximets wrote:
> On 9/1/25 12:10 PM, Eelco Chaudron via dev wrote:
>> This series fixes a couple of issues reported by Coverity.
>> Only the ofproto one might potentially require a backport,
>> the rest of them should be fine, and have no Fixes tag.
>>
>> v2:
>> - Patch 1:
>> - Replaced the assert with an explicit condition check
>> in ovsdb_monitor_row_update_type().
>> - Patch 6:
>> - Move the assert out of the loop + !datum->n check.
>>
>> Eelco Chaudron (6):
>> ofproto: Fix missing lock when reading oftable->vacancy_up/down.
>> ovsdb-monitor: Fix dereference after null check.
>> ovsdb-trigger: Fix dereference after null check.
>> ovsdb-relay: Fix dereference before null check.
>> ovsdb-raft: Fix dereference after null check.
>> ovsdb-transaction: Fix dereference after null check.
>
> nit: Normally, the 'area' part of the subject would be 'ovsdb: raft:'
> or 'ovsdb: relay:', i.e. not written with a dash, as we do not have
> actual files or modules named like this.
> But it's 'ovsdb-server' and 'ovsdb-client' as these are actual files.
>
> Maybe also clarify that it's not actually a dereference of a NULL
> pointer, but a benign warning. Maybe something like this:
>
> ovsdb: monitor: Silence dereference after null check warning.
>
> ?
>
> Also, in the last patch, the version history ended up in the commit
> message and not under the cut line.
>
> I assume all that can be fixed while applying. With that, for the set:
>
> Acked-by: Ilya Maximets <i.maxim...@ovn.org>
Thanks Ilya and Mike, for the reviews. Patches applied to main.
Cheers,
Eelco
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
