On 9/5/25 9:02 AM, Ales Musil wrote:
> On Wed, Sep 3, 2025 at 3:21 PM Dumitru Ceara via dev <
> [email protected]> wrote:
>
>> The '--n-ics' argument was essentially ignored. Now one can start a
>> sandbox with 0 ovn-ic daemons running in the following way:
>>
>> make sandbox SANDBOXFLAGS="--n-ics 0"
>>
>> Fixes: 381c9319b1f0 ("ovn-ic: Interconnection controller with AZ
>> registeration."
>> Signed-off-by: Dumitru Ceara <[email protected]>
>> ---
>> tutorial/ovn-sandbox | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tutorial/ovn-sandbox b/tutorial/ovn-sandbox
>> index ed334d1c31..a689eb30f9 100755
>> --- a/tutorial/ovn-sandbox
>> +++ b/tutorial/ovn-sandbox
>> @@ -251,7 +251,7 @@ EOF
>> n_ics=$optarg
>> ;;
>> --n-ic*)
>> - prev=n_ics_
>> + prev=n_ics
>> ;;
>> --n-controller*=*)
>> n_controllers=$optarg
>> --
>> 2.50.1
>>
>> _______________________________________________
>> dev mailing list
>> [email protected]
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>>
>>
> Looks good to me, thanks.
> Acked-by: Ales Musil <[email protected]>
>
Hi Ales,
Thanks for the review! Applied to main and all stable branches down to
24.03 as this helps with debugging.
Unfortunately, I had missed this malformed tag warning from ovsrobot
before applying the patch. I won't force push though as it's a minor thing.
checkpatch:
WARNING: The subject, '<area>: <summary>', is over 70 characters, i.e., 71.
Subject: ovn-sandbox: Fix typo that doesn't allow starting a sandbox
without IC.
ERROR: "Fixes" tag is malformed.
Use the following format:
git log -1 --pretty=format:"Fixes: %h (\"%s\")" --abbrev=12 COMMIT_REF
10: Fixes: 381c9319b1f0 ("ovn-ic: Interconnection controller with AZ
registeration."
Regards,
Dumitru
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
