On 8/29/25 10:19 AM, Ales Musil via dev wrote: > Consolidate the feature flags by removing the unused features > "port-up-notif", "ct-no-masked-label" nad "ovn-ct-lb-related". At > the same time make sure the debug command reports all the features > that are currently supported. And update the feature testing to > test all features that do not depend on OvS detection. > > Signed-off-by: Ales Musil <[email protected]> > ---
Hi Ales, > controller/chassis.c | 24 ------------------------ > include/ovn/features.h | 3 --- > northd/inc-proc-northd.c | 17 +++++++++++++++++ > tests/ovn-controller.at | 25 +++++++++++++++++++------ > tests/ovn-northd.at | 4 ++-- > 5 files changed, 38 insertions(+), 35 deletions(-) > [...] > diff --git a/northd/inc-proc-northd.c b/northd/inc-proc-northd.c > index bfb893a1a..e579f7787 100644 > --- a/northd/inc-proc-northd.c > +++ b/northd/inc-proc-northd.c > @@ -629,6 +629,23 @@ chassis_features_list(struct unixctl_conn *conn, int > argc OVS_UNUSED, > > ds_put_format(&ds, "mac_binding_timestamp: %s\n", > features->mac_binding_timestamp ? "true" : "false"); > + ds_put_format(&ds, "fdb_timestamp: %s\n", > + features->fdb_timestamp ? "true" : "false"); > + ds_put_format(&ds, "ls_dpg_column: %s\n", > + features->ls_dpg_column ? "true" : "false"); > + ds_put_format(&ds, "ct_commit_nat_v2: %s\n", > + features->ct_commit_nat_v2 ? "true" : "false"); > + ds_put_format(&ds, "ct_commit_to_zone: %s\n", > + features->ct_commit_to_zone ? "true" : "false"); > + ds_put_format(&ds, "sample_with_reg: %s\n", > + features->sample_with_reg ? "true" : "false"); > + ds_put_format(&ds, "ct_next_zone: %s\n", > + features->ct_next_zone ? "true" : "false"); > + ds_put_format(&ds, "ct_label_flush: %s\n", > + features->ct_label_flush ? "true" : "false"); > + ds_put_format(&ds, "ct_state_save: %s\n", > + features->ct_state_save ? "true" : "false"); > + I fixed up the indentation here and applied the patch to main. Thanks for the follow up and cleanup! Regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
