On Wed, Sep 10, 2025 at 9:53 AM Dumitru Ceara <[email protected]> wrote:
> On 9/9/25 3:22 PM, Ales Musil wrote: > > The action wasn't used since 24.09. Deprecate it so it can > > be removed in later releases. > > > > Signed-off-by: Ales Musil <[email protected]> > > --- > > Hi Ales, > > Thanks for the patch! > > > TODO.rst | 4 ++++ > > lib/actions.c | 2 ++ > > 2 files changed, 6 insertions(+) > > > > diff --git a/TODO.rst b/TODO.rst > > index 72218964c..cda5f0d99 100644 > > --- a/TODO.rst > > +++ b/TODO.rst > > @@ -189,6 +189,10 @@ but it will still be parsed and processed. There > should be also clearly stated > > when the feature/action will move from ``Deprecated`` to ``Removed``. > > ``Removed`` will print a warning and won't be processed further. > > > > +* 26.03 Deprecated > > + > > + * ``ct_lb`` action, should be removed in 26.09. > > + > > * 26.03 Removed > > > > * ``PUT_ICMP4_FRAG_MTU`` action > > diff --git a/lib/actions.c b/lib/actions.c > > index 98ab368fc..9829d8d6d 100644 > > --- a/lib/actions.c > > +++ b/lib/actions.c > > @@ -5900,6 +5900,8 @@ parse_action(struct action_context *ctx) > > } else if (lexer_match_id(ctx->lexer, "ct_snat_in_czone")) { > > parse_CT_SNAT_IN_CZONE(ctx); > > } else if (lexer_match_id(ctx->lexer, "ct_lb")) { > > + VLOG_WARN("The \"ct_lb\" action is deprecated please consider > using" > > + " a different action."); > > I think this should be rate limited. > > > parse_ct_lb_action(ctx, false); > > } else if (lexer_match_id(ctx->lexer, "ct_lb_mark")) { > > parse_ct_lb_action(ctx, true); > > With that addressed: > Acked-by: Dumitru Ceara <[email protected]> > > Regards, > Dumitru > > Thank you Dumitru, I have added the rate limiting, went ahead and merged this into main. Regards, Ales _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
