net/tap fixes were merged as part of v21.11.6/v22.11.4/v23.11 DPDK LTS versions.
A net/txgbe fix was merged as part of v21.11.9/v22.11.7/v23.11.3/v24.11 DPDK LTS versions. We can remove the capability filtering workarounds now that OVS main branch requires at least v24.11. Link: https://git.dpdk.org/dpdk/commit/drivers/net/tap?id=0bbafe48ae0a Link: https://git.dpdk.org/dpdk/commit/drivers/net/txgbe?id=25fe1c780d39 Signed-off-by: David Marchand <[email protected]> --- lib/netdev-dpdk.c | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 17b4d66779..07fca319a1 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -1359,26 +1359,6 @@ dpdk_eth_dev_init(struct netdev_dpdk *dev) dev->hw_ol_features &= ~NETDEV_RX_HW_SCATTER; } - if (!strcmp(info.driver_name, "net_tap")) { - /* FIXME: L4 checksum offloading is broken in DPDK net/tap driver. - * This workaround can be removed once the fix makes it to a DPDK - * LTS release used by OVS. */ - VLOG_INFO("%s: disabled Tx L4 checksum offloads for a net/tap port.", - netdev_get_name(&dev->up)); - info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_UDP_CKSUM; - info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_TCP_CKSUM; - } - - if (!strcmp(info.driver_name, "net_txgbe")) { - /* FIXME: Driver advertises the capability but doesn't seem - * to actually support it correctly. Can remove this once - * the driver is fixed on DPDK side. */ - VLOG_INFO("%s: disabled Tx outer udp checksum offloads for a " - "net/txgbe port.", - netdev_get_name(&dev->up)); - info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM; - } - if (info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_IPV4_CKSUM) { dev->hw_ol_features |= NETDEV_TX_IPV4_CKSUM_OFFLOAD; } else { -- 2.51.0 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
