On 9/10/25 4:47 AM, Ihar Hrachyshka wrote: A small commit message would be good to have.
> Signed-off-by: Ihar Hrachyshka <[email protected]> > --- > tests/tunnel.at | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/tunnel.at b/tests/tunnel.at > index 09e3c94c7..24219350a 100644 > --- a/tests/tunnel.at > +++ b/tests/tunnel.at > @@ -1066,7 +1066,7 @@ OVS_VSWITCHD_START([add-port br0 p1 -- set Interface p1 > type=vxlan \ > AT_CHECK([ovs-vsctl add-port br0 p2 -- set Interface p2 type=vxlan > options:dst_port=9000 \ > options:remote_ip=flow options:exts=gbp > ofport_request=2]) > > -AT_CHECK([grep p2 ovs-vswitchd.log | sed "s/^.*\(bridge br0:.*\)$/\1/"], [0], > +AT_CHECK([grep 'bridge br0: added interface p2' ovs-vswitchd.log | sed > "s/^.*\(bridge br0:.*\)$/\1/"], [0], > [bridge br0: added interface p2 on port 2 > ]) > The point of this test is to capture either: bridge br0: added interface p2 on port 2 or p2: could not set configuration (File exists) That's why the grep is so broad as it tries to capture both log strings. With this change we're no longer capturing the potential failure. The test will still fail, but the output will be less pretty. We can change the test, but then it doesn't make much sense to do a grep, then sed and then the check. We may as well just run a single 'grep -q' instead. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
