On 9/24/25 12:25 PM, Ales Musil wrote: > On Wed, Sep 24, 2025 at 12:21 PM Dumitru Ceara <[email protected]> wrote: > >> While the comment was inaccurate, the implementation is correct. >> >> Fixes: 3826e4071afb ("controller: Create physical flows based on the >> advertised EVPN FDBs.") >> Signed-off-by: Dumitru Ceara <[email protected]> >> --- >> controller/neighbor-exchange-netlink.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/controller/neighbor-exchange-netlink.c >> b/controller/neighbor-exchange-netlink.c >> index a9a3dc53db..66711d4980 100644 >> --- a/controller/neighbor-exchange-netlink.c >> +++ b/controller/neighbor-exchange-netlink.c >> @@ -180,7 +180,7 @@ ne_is_valid_remote_vtep(struct ne_nl_received_neigh >> *ne) >> (ne->state & NUD_PERMANENT); >> } >> >> -/* OVN expects that the FDB entry doesn't have any IP address (zeroed >> out), >> +/* OVN expects that the FDB entry has an IP address (that of the remote >> VTEP), >> * has MAC address and the entry is marked as "extern learned". */ >> bool >> ne_is_valid_static_fdb(struct ne_nl_received_neigh *ne) >> -- >> 2.51.0 >> >> > Looks good to me, thanks. > Acked-by: Ales Musil <[email protected]> >
Thanks, Ales, for the review! Applied to main and 25.09. Regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
