On Wed, Oct 8, 2025 at 12:51 PM Dumitru Ceara <[email protected]> wrote:
> Hi Ales, > > On 10/7/25 8:35 AM, Ales Musil via dev wrote: > > While the long long is defined as minimal of 64 bit width, meaning > > that it could change in the future to be wider e.g. 128. However, the > > *_cfg columns are defined as int64_t so always begin 64 bits. Replace > > I'm not sure what you meant with "so always begin 64 bits". Did you > mean "so always max 64 bits"? > That's a typo "being 64 bits" is what I meant. > > > the LLONG_MAX in potential overflow checks with INT64_MAX instead, > > that will guarantee that even a change of long long width in the > > future won't break this. > > > > Signed-off-by: Ales Musil <[email protected]> > > --- > > ic/ovn-ic.c | 2 +- > > tests/ovn-controller.at | 4 ++-- > > utilities/ovn-ic-nbctl.c | 2 +- > > utilities/ovn-nbctl.c | 2 +- > > 4 files changed, 5 insertions(+), 5 deletions(-) > > > > The code change itself looks good to me, thanks! > > Acked-by: Dumitru Ceara <[email protected]> > > Regards, > Dumitru > > Thank you Dumitru, I have fixed the typo and merged this into main. Regards, Ales _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
