Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#61 FILE: northd/northd.c:1885:
vector_push(&op->od->proxy_arp_addrs, &op->proxy_arp_addrs);
ERROR: Improper whitespace around control block
#106 FILE: northd/northd.c:9883:
VECTOR_FOR_EACH_PTR(&op->od->proxy_arp_addrs, proxy_arp_addrs) {
WARNING: Line is 85 characters long (recommended limit is 79)
#110 FILE: northd/northd.c:9887:
struct ipv4_netaddr *ipv4_addr =
&op->lsp_addrs[i].ipv4_addrs[k];
WARNING: Line is 82 characters long (recommended limit is 79)
#111 FILE: northd/northd.c:9888:
ovs_be32 proxy_arp_mask =
proxy_arp_addrs->ipv4_addrs[j].mask;
WARNING: Line is 88 characters long (recommended limit is 79)
#112 FILE: northd/northd.c:9889:
ovs_be32 proxy_arp_network =
proxy_arp_addrs->ipv4_addrs[j].network;
WARNING: Line is 82 characters long (recommended limit is 79)
#113 FILE: northd/northd.c:9890:
if ((ipv4_addr->addr & proxy_arp_mask) !=
proxy_arp_network) {
WARNING: Line is 85 characters long (recommended limit is 79)
#128 FILE: northd/northd.c:9905:
struct ipv6_netaddr *ipv6_addr =
&op->lsp_addrs[i].ipv6_addrs[k];
WARNING: Line is 91 characters long (recommended limit is 79)
#129 FILE: northd/northd.c:9906:
struct in6_addr *proxy_arp_mask =
&proxy_arp_addrs->ipv6_addrs[j].mask;
WARNING: Line is 97 characters long (recommended limit is 79)
#130 FILE: northd/northd.c:9907:
struct in6_addr *proxy_arp_network =
&proxy_arp_addrs->ipv6_addrs[j].network;
WARNING: Line is 97 characters long (recommended limit is 79)
#131 FILE: northd/northd.c:9908:
struct in6_addr network =
ipv6_addr_bitand(&ipv6_addr->addr, proxy_arp_mask);
Lines checked: 396, Warnings: 9, Errors: 1
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
