Originally reported by coverity as:
>>> CID 490437: Null pointer dereferences (FORWARD_NULL)
>>> Dereferencing null pointer "op->sb".
3147 port_up = port_up && (op->sb->n_up && op->sb->up[0]);
However, op->sb can never be NULL here.
Fixes: b42edf4a43b3 ("northd, controller, tests: Network Function Health
monitoring.")
Signed-off-by: Dumitru Ceara <[email protected]>
---
northd/northd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/northd/northd.c b/northd/northd.c
index 4a3463a8e8..886fe2f98a 100644
--- a/northd/northd.c
+++ b/northd/northd.c
@@ -3135,7 +3135,7 @@ ovn_nf_svc_create(struct ovsdb_idl_txn *ovnsb_txn,
return;
}
- if (op->sb && op->sb->chassis) {
+ if (op->sb->chassis) {
if (chassis_name == NULL) {
chassis_name = op->sb->chassis->name;
} else if (strcmp(chassis_name, op->sb->chassis->name)) {
--
2.51.0
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
