On 9/26/25 5:59 PM, Kevin Traynor wrote:
> On 12/09/2025 12:27, Ilya Maximets wrote:
>> AppVeyor had an issue where C:\OpenSSL-Win64 folder didn't exist for
>> some reason and the installation of OpenSSL was placing it into
>> C:\Program Files\OpenSSL-Win64 instead as well.  After that we couldn't
>> find the libraries and the build failed:
>>   
>> https://help.appveyor.com/discussions/problems/38517-cannot-find-path-copenssl-win64-because-it-does-not-exist
>>
>> The issue was resolved since, but it's better if we check the paths
>> and install into specific location to be more resilient to this kind
>> of environment issues, i.e. make less assumptions.
>>
>> While at it, fixing the slash type for the path.  Remove-Item somehow
>> accepts the "wrong" one, but a backslash is more native in paths on
>> Windows.  We use forward slash while in msys2 shell, but should not use
>> it in PowerShell environment.
>>
>> Signed-off-by: Ilya Maximets <[email protected]>
>> ---
>>  appveyor.yml | 14 +++++++++++---
>>  1 file changed, 11 insertions(+), 3 deletions(-)
>>
>> diff --git a/appveyor.yml b/appveyor.yml
>> index 5ddbde0ca..28a75c3af 100644
>> --- a/appveyor.yml
>> +++ b/appveyor.yml
>> @@ -19,7 +19,10 @@ cache:
>>  
>>  install:
>>  - ps: |
>> -    Remove-Item -Recurse -Force -Path C:/OpenSSL-Win64
>> +    $OpenSSLPath = "C:\OpenSSL-Win64"
>> +    if (Test-Path $OpenSSLPath) {
>> +        Remove-Item -Recurse -Force -Path $OpenSSLPath
>> +    }
>>      New-Item -ItemType Directory -Force -Path C:\ovs-build-downloads
>>  
>>      # Find and download the latest stable OpenSSl 3.0.
>> @@ -52,8 +55,13 @@ install:
>>      }
>>  
>>      Write-Host "Installing:" $destination
>> -    Start-Process -FilePath $destination `
>> -        -ArgumentList "/silent /verysilent /sp- /suppressmsgboxes" -Wait
>> +    $installArgs = @{
>> +        FilePath     = $destination
>> +        ArgumentList = '/silent /verysilent /sp- /suppressmsgboxes ' +
>> +                       '/DIR="' + $OpenSSLPath + '"'
>> +        Wait         = $true
>> +    }
>> +    Start-Process @installArgs
>>  
>>  - ps: git clone -q https://git.code.sf.net/p/pthreads4w/code 
>> c:\pthreads4w-code
>>  - ps: python3 -m pip install pypiwin32 --disable-pip-version-check
> 
> Tested and see that openssl is found with this patch.
> 
> 'checking whether compiling and linking against OpenSSL works... yes'
> 
> Similar to Eelco, I do see another failure (see below), but I don't
> think it's caused by this patch, so
> 
> Acked-by: Kevin Traynor <[email protected]>
> 
> --
> 
> With current VS 2019:
> 
> checking absolute name of <stdio.h>... ""
> checking absolute name of <string.h>... ""
> 
> Working with: 'Previous Visual Studio 2019':
> 
> checking absolute name of <stdio.h>... "C:\\Program Files (x86)\\Windows
> Kits\\10\\include\\10.0.22000.0\\ucrt\\stdio.h"
> checking absolute name of <string.h>... "C:\\Program Files
> (x86)\\Windows Kits\\10\\include\\10.0.22000.0\\ucrt\\string.h"

Yeah, I saw this one as well, but was hoping that it was resolved,
but both issues reappeared...  I replied to my original thread in
their discussion forum.  For now, I'll send a patch to move to the
"Previous" image temporarily.  It seems to work fine.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to