Hi Jacob Thanks for the patch Acked-by: Xavier Simonart <[email protected]>
Thanks Xavier On Wed, Oct 8, 2025 at 5:45 PM Jacob Tanenbaum via dev < [email protected]> wrote: > This check was brought in during refactor 876179... it was a mistake to > copy this check from sync_to_sb_lb_northd_handler() and the tracking of > lbs has nothing to do with what is going on in > sync_to_sb_pb_northd_handler() > > Co-authored-by: Mark Michelson <[email protected]> > Signed-off-by: Mark Michelson <[email protected]> > Signed-off-by: Jacob Tanenbaum <[email protected]> > Fixes: 876179c674cd ("northd: Refactor the northd change tracking.") > > diff --git a/northd/en-sync-sb.c b/northd/en-sync-sb.c > index f415d59c8..65b88a371 100644 > --- a/northd/en-sync-sb.c > +++ b/northd/en-sync-sb.c > @@ -409,9 +409,8 @@ enum engine_input_handler_result > sync_to_sb_pb_northd_handler(struct engine_node *node, void *data > OVS_UNUSED) > { > struct northd_data *nd = engine_get_input_data("northd", node); > - if (!northd_has_tracked_data(&nd->trk_data) || > - northd_has_lbs_in_tracked_data(&nd->trk_data)) { > - /* Return false if no tracking data or if lbs changed. */ > + if (!northd_has_tracked_data(&nd->trk_data)) { > + /* Return false if no tracking data */ > return EN_UNHANDLED; > } > > -- > 2.51.0 > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
