The ADD_VETH() / ADD_VETH_BOND() macros didn't schedule deletion of the test interfaces (by calling 'on_exit') immediately after the interfaces were created. That means that in the eventuality of a command failure in between creation and the call to 'on_exit' the test interfaces wouldn't be cleaned up.
Acked-by: Xavier Simonart <[email protected]> Signed-off-by: Dumitru Ceara <[email protected]> --- tests/system-common-macros.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at index a26e5f1dac..604a1935fb 100644 --- a/tests/system-common-macros.at +++ b/tests/system-common-macros.at @@ -60,6 +60,7 @@ m4_define([ADD_BR], [ovs-vsctl _ADD_BR([$1]) -- $2]) # m4_define([ADD_VETH], [ AT_CHECK([ip link add $1 type veth peer name ovs-$1]) + on_exit "ip link del ovs-$1" CONFIGURE_VETH_OFFLOADS([$1]) AT_CHECK([ip link set $1 netns $2]) AT_CHECK([ip link set dev ovs-$1 up]) @@ -80,7 +81,6 @@ m4_define([ADD_VETH], if test -n "$9"; then NS_CHECK_EXEC([$2], [ip route add default via $9]) fi - on_exit "ip link del ovs-$1" ] ) -- 2.51.0 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
