On 10/17/25 4:54 PM, Eelco Chaudron wrote: > > > On 15 Oct 2025, at 16:59, Eli Britstein wrote: > >> Instead of dedicated dpdk properties in the schema (dpdk_initialized, >> dpdk_version), introduce a generic 'libraries' table, for key-value >> pairs, making it generic and expandable for future libraries. >> DPDK fills it instead of the special properties. > > Hi Eli, > > Not a full review, just one quick note: you cannot delete items from a > schema for backward compatibility reasons.
That's true. Removing tables/columns from the schema will break any client that monitors the database. Also, users that monitor these columns likely relying on the information provided. So, the solution here is to deprecate the columns, but keep populating them with data. After at least one release have passed, we can stop populating them, but we can't really remove them. > > As Ilya is already included, any thoughts on the new libraries table? It seems a little strange to have a single column mixing configuration and status from potentially different libraries. Since we're changing the schema, I'd suggest we create a new table with a few columns like "name", "config" and "status". And make this new "libraries" column contain references to rows in the "libraries" table. This way each library can have its own row with a config and a status string maps. "initialized" can be a separate boolean column, and maybe "error" to populate with an error string when initialization fails. "config" would be a significant API change to how we configure DPDK today. But we can deprecate the current method, allow both for the time being and stop supporting the old one eventually. But it would be much cleaner in the way that each library will have its own place for configuration with no magic prefixes required. And one would enable DPDK by adding a dpdk library via ovs-vsctl, e.g.: ovs-vsctl add-library [name] [option [option ...]]. ovs-vsctl add-library dpdk vhost-sock-dir=/tmp/vhost socket-mem=1024 Might be a bit ambitious to change the way we configure dpdk, I agree. So, maybe not all at once. WDYT? CC: David, Kevin. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
