On Tue, 18 Nov 2025 at 09:09, 0-day Robot <[email protected]> wrote: > > +dnl CHECK_IP_CHECKSUMS rx_port tx_port good_pkt bad_pkt good_exp bad_exp > > +dnl > > +dnl Test combinations of Rx IP checksum flags for a good or bad packet > > +dnl received on rx_port, and sent over tx_port. > > +m4_define([CHECK_IP_CHECKSUMS], > > + [dnl Checks for good packet. > > + dnl No Rx flag > > + CHECK_FWD_PACKET($1, $2, , $3, $5) > > + dnl Rx good > > + CHECK_FWD_PACKET($1, $2, ol_ip_rx_csum_set_good, $3, $5) > > + dnl Rx bad > > + CHECK_FWD_PACKET($1, $2, ol_ip_rx_csum_set_bad, $3, $5) > > + dnl Rx partial > > + CHECK_FWD_PACKET($1, $2, ol_ip_rx_csum_set_partial, $3, $5) > > + > > + dnl Checks for bad packet. > > + dnl No Rx flag > > + CHECK_FWD_PACKET($1, $2, , $4, $6) > > + dnl Rx good > > + CHECK_FWD_PACKET($1, $2, ol_ip_rx_csum_set_good, $4, $5) > > + dnl Rx bad > > + CHECK_FWD_PACKET($1, $2, ol_l4_rx_csum_set_bad, $4, $6) > > Is there a copy-paste error in this line? The macro name is > CHECK_IP_CHECKSUMS but this line uses "ol_l4_rx_csum_set_bad". Should > this be "ol_ip_rx_csum_set_bad"?
Erm, I can overlook hallucinations in comments, but hallucinating on the content to review is bad... This hunk does not exit in the series I posted: https://github.com/ovsrobot/ovs/commit/c84b2df59feeb3db7da99c763512074e5942b0ab#diff-504ac5dd7fd61e32916a60d8e1f936699e1375f5bdf0dca52e649e99eebaab0bR746-R765 Am I missing something obvious? -- David Marchand _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
