Thanks for the patch.

Acked-by: Mark Michelson <[email protected]>

On Wed, Nov 19, 2025 at 2:20 PM Guru Shetty <[email protected]> wrote:
>
> Is the 79 character limit applicable for shell scripts? I see lines
> previously added above the limit.

IIRC, the only code-like file types where we disable line length
checks are testsuite files (those ending in *.at). The line length
limit is checked on all other code-like files (C files, python files,
shell scripts). However, the line length warning is only a warning,
not an error. So in this particular case, it's totally fine that the
lines are greater than 79 characters.

>
> On Wed, 19 Nov 2025 at 11:18, 0-day Robot <[email protected]> wrote:
>
> > Bleep bloop.  Greetings Gurucharan Shetty, I am a robot and I have tried
> > out your patch.
> > Thanks for your contribution.
> >
> > I encountered some error that I wasn't expecting.  See the details below.
> >
> >
> > checkpatch:
> > WARNING: Line is 82 characters long (recommended limit is 79)
> > #193 FILE: utilities/ovn-ctl:1299:
> >   --ovn-ic-nb-db-ssl-server-name=NAME OVN IC Northbound DB TLS server name
> > for SNI
> >
> > WARNING: Line is 82 characters long (recommended limit is 79)
> > #200 FILE: utilities/ovn-ctl:1306:
> >   --ovn-ic-sb-db-ssl-server-name=NAME OVN IC Southbound DB TLS server name
> > for SNI
> >
> > WARNING: Line is 88 characters long (recommended limit is 79)
> > #208 FILE: utilities/ovn-ctl:1467:
> >   --ovn-sb-relay-db-ssl-server-name=NAME OVN Southbound DB relay TLS
> > server name for SNI
> >
> > Lines checked: 234, Warnings: 3, Errors: 0
> >
> >
> > Please check this out.  If you feel there has been an error, please email
> > [email protected]
> >
> > Thanks,
> > 0-day Robot
> >
> _______________________________________________
> dev mailing list
> [email protected]
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to