Thanks Ales!

Acked-by: Mark Michelson <[email protected]>

Since this is so simple, I went ahead and merged this to main,
branch-25.09, and branch-25.03.

On Thu, Nov 20, 2025 at 6:50 AM Ales Musil via dev
<[email protected]> wrote:
>
> The FDB was using the MAC Binding drop counter which isn't correct.
> Use the proper one instead.
>
> Fixes: fb96ae36793a ("controller: Merge the mac-cache and mac-learn.")
> Signed-off-by: Ales Musil <[email protected]>
> ---
>  controller/pinctrl.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/controller/pinctrl.c b/controller/pinctrl.c
> index 2fb2dcded..fdb1527c1 100644
> --- a/controller/pinctrl.c
> +++ b/controller/pinctrl.c
> @@ -383,6 +383,7 @@ static void pinctrl_handle_put_fdb(const struct flow *md,
>  static void set_from_ctrl_flag_in_pkt_metadata(struct ofputil_packet_in *);
>
>  COVERAGE_DEFINE(pinctrl_drop_put_mac_binding);
> +COVERAGE_DEFINE(pinctrl_drop_put_fdb);
>  COVERAGE_DEFINE(pinctrl_drop_buffered_packets_map);
>  COVERAGE_DEFINE(pinctrl_drop_controller_event);
>  COVERAGE_DEFINE(pinctrl_drop_put_vport_binding);
> @@ -8828,7 +8829,7 @@ pinctrl_handle_put_fdb(const struct flow *md, const 
> struct flow *headers)
>                         OVS_REQUIRES(pinctrl_mutex)
>  {
>      if (hmap_count(&put_fdbs) >= MAX_FDB_ENTRIES) {
> -        COVERAGE_INC(pinctrl_drop_put_mac_binding);
> +        COVERAGE_INC(pinctrl_drop_put_fdb);
>          return;
>      }
>
> --
> 2.51.1
>
> _______________________________________________
> dev mailing list
> [email protected]
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to