On Thu, Dec 4, 2025 at 12:29 PM Dumitru Ceara <[email protected]> wrote:
> On 12/3/25 1:58 PM, Ales Musil via dev wrote:
> > To learn BGP routes OVN would only check if the protocol is set
> > to RTPROT_OVN (84), as that would indicate route installed by OVN
> > which we don't want to learn. However, this condition would lead
> > to OVN learning also static routes which is not desirable. Make sure
> > we skip the routes that have procol <= RTPROT_STATIC (4).
> >
> > Fixes: 866a5014ae45 ("controller: Support learning routes.")
> > Reported-at: https://issues.redhat.com/browse/FDP-2739
> > Signed-off-by: Ales Musil <[email protected]>
> > ---
>
> Hi Ales,
>
> Thanks for the fix!
>
> > controller/route-exchange-netlink.c | 8 +-
> > tests/system-ovn.at | 118 ++++++++++++++--------------
> > 2 files changed, 68 insertions(+), 58 deletions(-)
> >
> > diff --git a/controller/route-exchange-netlink.c
> b/controller/route-exchange-netlink.c
> > index bc1488018..058b05878 100644
> > --- a/controller/route-exchange-netlink.c
> > +++ b/controller/route-exchange-netlink.c
> > @@ -212,8 +212,14 @@ handle_route_msg(const struct route_table_msg *msg,
> void *data)
> > return;
> > }
> >
> > - /* This route is not from us, so we learn it. */
> > + /* This route is not from us, learn it only if it's > RTPROT_STATIC,
> > + * those protocol values are used by dynamic routing protocols.
> > + * This should prevent us from learning static routes installed
> > + * by user in the VRF. */
>
> Nit: s/user/users/
>
> Aside from this the rest looks good to me:
>
> Acked-by: Dumitru Ceara <[email protected]>
>
> Regards,
> Dumitru
>
>
Thank you Dumitru,
I have addressed the nit, went ahead and merged this into main and
backported to 25.03.
Regards,
Ales
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
