`find_command` test helper assumes `which` is present on the system. If it is not, the helper silently fails to detect an installed command presence, skipping tests that a caller could expect to run (since the auxiliary commands *are* installed).
Other build scripts and test cases also use the command, and we install it in the fedora container too. This patch enforces `which` presence via autoconf. Signed-off-by: Ihar Hrachyshka <[email protected]> --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index 2f67f9512..ef4ce9ad6 100644 --- a/configure.ac +++ b/configure.ac @@ -29,6 +29,9 @@ AC_PROG_CPP AC_PROG_MKDIR_P AC_PROG_FGREP AC_PROG_EGREP +AC_PATH_PROG([WHICH], [which]) +AS_IF([test -z "$WHICH"], + [AC_MSG_ERROR([which command is required to build OVN])]) PKG_PROG_PKG_CONFIG AM_MISSING_PROG([AUTOM4TE], [autom4te]) -- 2.51.2 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
