Commit d1f4150bbe88 ("tests: Ensure all central components stop at the
end of the test.") tried to address the missing cleanup for northd in
OVN tests. It only partially managed to do that. It also turns out we
were missing lots of other cleanups in our tests which could potentially
hide issues, e.g., when the tests are run with sanitizers enabled.
NOTE: ideally this all should be done in a more reliable way, e.g., by
having all the _START() helpers register proper cleanup code instead
relying on the test writer to call the correct cleanup macros. But
until we get that (Xavier is looking into it) we might as well fix up
our current tests.
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-dev/2025-December/428375.html
Reported-by: Xavier Simonart <[email protected]>
V2:
- turned this into a series that handles more of the cleanup issues in
our tests (thanks to Xavier's report on the v1 patch!)
Dumitru Ceara (8):
tests: Add missing OVN_CLEANUP_NORTHD calls.
tests/ovn-controller-vtep: Add missing OVN_CONTROLLER_VTEP_STOP calls.
tests/ovn-controller-vtep: Remove unused test net.
tests: Add OVN_CLEANUP_DBS and use it in tests that already stopped
northd.
tests/ovn: Add missing OVN_CLEANUP calls.
tests/ovn: Add missing partial cleanups.
tests/ovn-controller: Add missing cleanup.
tests/ovn-ic: Add missing OVN_CLEANUP_IC call.
tests/ovn-controller-vtep.at | 12 +++++++-
tests/ovn-controller.at | 50 +++++++++-------------------------
tests/ovn-ic.at | 2 ++
tests/ovn-macros.at | 13 +++++++--
tests/ovn-northd.at | 2 ++
tests/ovn.at | 53 +++++++++++++++++++++++++-----------
tests/perf-northd.at | 4 +++
tests/system-ovn.at | 9 +-----
8 files changed, 80 insertions(+), 65 deletions(-)
--
2.51.1
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
