On Fri, May 6, 2022 at 9:46 AM Daniel Alvarez Sanchez <dalva...@redhat.com> wrote: > > Hi folks, > > While doing some tests with PXE booting and OVN, we noticed that even though > the tftp-server option was sent by ovn-controller, the baremetal node > wouldn't try to reach it to download the image. Comparing it to the output > sent by dnsmasq, it looks like we're missing the next server option. >
Thanks for describing the issue, Daniel > After this 'hardcoded' [0] (and dirty) patch, it seemed to work. > Yes, we tested it with real hardware and it works! > Is this something we should add to OVN? For example, when the tftp-* options > are set in the DHCP_Options table, have ovn-controller send the next-server > address in the DHCP offer? > I would suggest using the "tftp_server_address" (DHCP Opt 150) for this, there's the "tftp_server" (DHCP Opt 66) option as well but this one also accepts a hostname. So, the way I would go about it is: When option 150 is set we also set the next-server field in the header [1] with the same IP address specified in that option. [1] https://github.com/openvswitch/ovs/blob/f8be30acf2eb60d567bb7386b98f5cb58ddb9119/lib/dhcp.h#L42 Cheers, Lucas > Thanks! > daniel > > [0] > > > diff --git a/controller/pinctrl.c b/controller/pinctrl.c > index ae3da332c..6c2c75a64 100644 > --- a/controller/pinctrl.c > +++ b/controller/pinctrl.c > @@ -2259,6 +2259,7 @@ pinctrl_handle_put_dhcp_opts( > > if (*in_dhcp_msg_type != OVN_DHCP_MSG_INFORM) { > dhcp_data->yiaddr = (msg_type == DHCP_MSG_NAK) ? 0 : *offer_ip; > + dhcp_data->siaddr = (ovs_be32) inet_addr("172.27.7.29"); > } else { > dhcp_data->yiaddr = 0; > } > _______________________________________________ > discuss mailing list > disc...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-discuss _______________________________________________ discuss mailing list disc...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-discuss
