OpenBSD src changes summary for 2016-02-07 to 2016-02-14 inclusive ==================================================================
bin/df distrib/alpha distrib/amd64 distrib/armish distrib/armv7 distrib/hppa distrib/i386 distrib/landisk distrib/loongson distrib/luna88k distrib/macppc distrib/miniroot distrib/notes distrib/octeon distrib/socppc distrib/sparc distrib/sparc64 distrib/vax distrib/zaurus etc/examples/pkg.conf etc/rc.d/bgpd etc/rc.d/dvmrpd games/snake lib/libc lib/libsndio regress/lib sbin/wsconsctl share/man sys/arch/amd64/amd64 sys/arch/amd64/include sys/arch/amd64/stand/libsa sys/arch/hppa/include sys/arch/hppa64/include sys/arch/i386/stand/libsa sys/ddb sys/dev sys/dev/hid sys/dev/ic sys/dev/pci sys/dev/usb sys/kern sys/net sys/net80211 sys/netinet sys/nfs sys/ntfs usr.bin/doas usr.bin/hexdump usr.bin/openssl usr.bin/ssh usr.bin/tmux usr.bin/vi usr.sbin/dhcpd usr.sbin/dhcrelay usr.sbin/ftp-proxy usr.sbin/httpd usr.sbin/ospf6d usr.sbin/pkg_add usr.sbin/radiusd usr.sbin/rtadvd usr.sbin/smtpd usr.sbin/tftp-proxy usr.sbin/tokeninit usr.sbin/traceroute usr.sbin/vmd == bin =============================================================== 01/11 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/bin df ~ df.c ~ ext2fs_df.c ~ ffs_df.c > remove needless headers > ok tb@, from Michal Mazurek (mmcc@) == distrib =========================================================== 02/11 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/distrib alpha ~ common/install.md > If manual disklabel editing is requested during install, don't emit > verbiage explaining what disklabels are. > If you don't know, you should be using (A)uto! > ok rpe@ halex@ (krw@) amd64 ~ common/install.md > If manual disklabel editing is requested during install, don't emit > verbiage explaining what disklabels are. > If you don't know, you should be using (A)uto! > ok rpe@ halex@ (krw@) armish ~ ramdisk/install.md > If manual disklabel editing is requested during install, don't emit > verbiage explaining what disklabels are. > If you don't know, you should be using (A)uto! > ok rpe@ halex@ (krw@) armv7 ~ ramdisk/install.md > If manual disklabel editing is requested during install, don't emit > verbiage explaining what disklabels are. > If you don't know, you should be using (A)uto! > ok rpe@ halex@ (krw@) hppa ~ install.md > If manual disklabel editing is requested during install, don't emit > verbiage explaining what disklabels are. > If you don't know, you should be using (A)uto! > ok rpe@ halex@ (krw@) i386 ~ common/install.md > If manual disklabel editing is requested during install, don't emit > verbiage explaining what disklabels are. > If you don't know, you should be using (A)uto! > ok rpe@ halex@ (krw@) landisk ~ ramdisk/install.md > If manual disklabel editing is requested during install, don't emit > verbiage explaining what disklabels are. > If you don't know, you should be using (A)uto! > ok rpe@ halex@ (krw@) loongson ~ ramdisk/install.md > If manual disklabel editing is requested during install, don't emit > verbiage explaining what disklabels are. > If you don't know, you should be using (A)uto! > ok rpe@ halex@ (krw@) luna88k ~ ramdisk/install.md > If manual disklabel editing is requested during install, don't emit > verbiage explaining what disklabels are. > If you don't know, you should be using (A)uto! > ok rpe@ halex@ (krw@) macppc ~ ramdisk/install.md > If manual disklabel editing is requested during install, don't emit > verbiage explaining what disklabels are. > If you don't know, you should be using (A)uto! > ok rpe@ halex@ (krw@) miniroot ~ install.sh > Ensure, that the '&' is placed correctly if not all variables are set. > While there do it with less code. > with feedback from and OK halex@ (rpe@) ~ install.sub > Uppercase global variable. > OK halex@ (rpe@) notes ~ hppa/features ~ macppc/features > The defines in the /usr/src/distrib/notes/<arch>/features files control > if certain parts of m4.common end up in the installation notes for an > archictecture. > - hppa has timezone info in bsd.rd now (according to list.local) > - the macppc install.md sets MDXDM=y. > OK shten@ (rpe@) ~ alpha/features ~ armv7/features ~ hppa/features ~ sparc/features ~ vax/features > Update the paths for install.md and the list files. > OK sthen@ (rpe@) ~ m4.common > Sync installation notes with reality. > - the manual netconfig step was removed from the installer six years ago > - ntpd is enabled by default now > OK millert@ (rpe@) ~ m4.common > - The question if you really want to upgrade is gone. > - Add part about TERM and keyboard layout question. > - "download" instead of "ftp get/reget" > Feedback from and OK sthen@ > OK millert@ (rpe@) ~ m4.common > - re-order the (I)nstall, (U)pgrade, (A)utoinstall part to match what > the installer shows and what the subsequent text describes. > - re-phrase the part about ssh logins as root. The installer now asks > "Allow root ssh login? (yes, no, prohibit-password)". Previously it > was "Since you set up a user, disable sshd(8) logins to root?" > OK krw@, sthen@ (rpe@) octeon ~ ramdisk/install.md > If manual disklabel editing is requested during install, don't emit > verbiage explaining what disklabels are. > If you don't know, you should be using (A)uto! > ok rpe@ halex@ (krw@) socppc ~ ramdisk/install.md > If manual disklabel editing is requested during install, don't emit > verbiage explaining what disklabels are. > If you don't know, you should be using (A)uto! > ok rpe@ halex@ (krw@) sparc ~ install.md > If manual disklabel editing is requested during install, don't emit > verbiage explaining what disklabels are. > If you don't know, you should be using (A)uto! > ok rpe@ halex@ (krw@) sparc64 ~ common/install.md > If manual disklabel editing is requested during install, don't emit > verbiage explaining what disklabels are. > If you don't know, you should be using (A)uto! > ok rpe@ halex@ (krw@) vax ~ install.md > If manual disklabel editing is requested during install, don't emit > verbiage explaining what disklabels are. > If you don't know, you should be using (A)uto! > ok rpe@ halex@ (krw@) zaurus ~ ramdisk/install.md > If manual disklabel editing is requested during install, don't emit > verbiage explaining what disklabels are. > If you don't know, you should be using (A)uto! > ok rpe@ halex@ (krw@) == etc =============================================================== 03/11 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/etc examples/pkg.conf ~ examples/pkg.conf > sync (sthen@) ~ examples/pkg.conf > sync (sthen@) rc.d/bgpd ~ rc.d/bgpd > Remove setproctitle() for the parent process. Because rc.d(8) uses process > titles (including flags) to distinguish between daemons, this makes it > possible to manage multiple copies of a daemon using the normal > infrastructure > by symlinking rc.d scripts to a new name. ok jung@ ajacoutot@, > missed in previous commit, problem reported by mxb/alumni/chalmers/se. > (sthen@) rc.d/dvmrpd ~ rc.d/dvmrpd > Remove setproctitle() for the parent process. Because rc.d(8) uses process > titles (including flags) to distinguish between daemons, this makes it > possible to manage multiple copies of a daemon using the normal > infrastructure > by symlinking rc.d scripts to a new name. ok jung@ ajacoutot@, > missed in previous commit noticed after re-checking following report in > bgpd. (sthen@) == games ============================================================= 04/11 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/games snake ~ snake.c > - Remove parameter fd from snscore() since it's never used > - And while here, fwrite(3) returns size_t whereas nscores is an int, so > cast > nscores to u_int. This is a false positive, but silences a compiler warning > with -Wextra -pedantic > tb@ : "Looks ok to me" after suggestion from him (mestre@) == lib =============================================================== 05/11 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib libc ~ stdlib/strtonum.3 > compare pointer to NULL in example code (mmcc@) ~ locale/mbrtowc.3 > Align with reality, and with POSIX: For this particular function, > incomplete characters are not an error, do not throw EILSEQ, and > are not supposed to. > OK millert@ (schwarze@) ~ time/strftime.3 ~ time/strptime.3 > mention mktime, since that is where struct tm is described. ok schwarze > (tedu@) ~ time/strftime.3 > new sentence, new line; (jmc@) ~ sys/pledge.2 > Document how to use sndio in pledged programs. > Input and OK jmc@ ratchov@ semarie@ (tim@) ~ locale/wctomb.3 > Fix an obvious cut-and-paste error: > This function doesn't even have an "n" argument, so that non-existent > argument clearly cannot restrict the return value. (schwarze@) ~ locale/wctomb.3 > Dv fix; (jmc@) libsndio ~ sio_open.3 > Document how to use sndio in pledged programs. > Input and OK jmc@ ratchov@ semarie@ (tim@) == regress =========================================================== 06/11 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/regress lib + libedit/read/Makefile + libedit/read/test_read_char.c + libedit/read/test_read_char.sh > Slowly start a unit test suite for libedit; Christos is right that > fiddling with the internals of that code is dangerous without it. > Intentionally not linked to the build yet, because many of the tests > still fail: The related bugfixes are too intrusive right now and will > go in after unlock. (schwarze@) ~ libedit/read/test_read_char.c ~ libedit/read/test_read_char.sh > Test the C/POSIX locale too, in addition to UTF-8. (schwarze@) == sbin ============================================================== 07/11 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sbin wsconsctl ~ util.c > Permit negative x and y coordinates in mouse.scale for uts and ums. > Needed by some touchscreens. > no objection matthieu@ (guenther@) == share ============================================================= 08/11 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/share man ~ man8/ssl.8 > sslv3 has been removed; > prompted by a mail from jiri navratil > help/ok sthen (jmc@) ~ man9/srp_enter.9 > tweak the description and make it obvious updates can sleep. > based on discussion with haesbart and jmatthew (dlg@) ~ man9/srp_enter.9 > srp_update_get_locked doesnt exist, i meant srp_get_locked (dlg@) ~ man9/srp_enter.9 > i think this is a grammar fix (dlg@) == sys =============================================================== 09/11 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys arch/amd64/amd64 ~ pmap.c ~ vmm.c > Set EPT bits of guest pages in pmap_enter instead of doing it > after an uvm_fault: uvm_fault maps in neighboring pages of > the faulting page. We want EPT bits set for those as soon as > possible as well. This avoids additional EPT violations > causing further uvm_faults when the guest accesses the > neighboring pages. > discussion with and ok mlarkin@ (stefan@) arch/amd64/include ~ pmap.h > Set EPT bits of guest pages in pmap_enter instead of doing it > after an uvm_fault: uvm_fault maps in neighboring pages of > the faulting page. We want EPT bits set for those as soon as > possible as well. This avoids additional EPT violations > causing further uvm_faults when the guest accesses the > neighboring pages. > discussion with and ok mlarkin@ (stefan@) arch/amd64/stand/libsa ~ random_amd64.S ~ random_i386.S > Remove the "GenuineIntel" check from x86 mdrandom(). Checking the > CPU features is enough, and this enables the use of RDRAND and the > TSC fallback on CPUs from other vendors, notably AMD. > Tested in snapshots for a month. (naddy@) arch/hppa/include ~ atomic.h > make __cpu_simple_lock provide serialisation of the critical section. > that in turn makes atomic sequences actually atomic, which in turn > means the refcnt api asserts wont fire erronously when if_get and > if_put are actually used correctly. > such embarrassment. > reported by landry@ who also let me debug on the affected machines > ok jmatthew@ (dlg@) arch/hppa64/include ~ atomic.h > bring in dlg's fix from rev 1.10 of the equivalent hppa file: > make __cpu_simple_lock provide serialisation of the critical section. > that in turn makes atomic sequences actually atomic, which in turn > means the refcnt api asserts wont fire erronously when if_get and > if_put are actually used correctly. (jsg@) arch/i386/stand/libsa ~ random_i386.S > Remove the "GenuineIntel" check from x86 mdrandom(). Checking the > CPU features is enough, and this enables the use of RDRAND and the > TSC fallback on CPUs from other vendors, notably AMD. > Tested in snapshots for a month. (naddy@) ddb ~ db_sym.c ~ db_sym.h > Kill db_symbol_is_ambiguous(). There's no ambiguous symbol since LKMs > are no longer supported. > ok tb@, guenther@ (mpi@) dev ~ ipmi.c > Remove a too strict assertion. (uebayasi@) ~ ipmi.c > Comment. (uebayasi@) ~ video.c > Convert to uiomove. From Martin Natano. (stefan@) ~ ipmi.c > ipmi(4) - Check sensor name length more carefully > Don't blindly trust sensor name info returned from BMC. Check them more > carefully. Prevent DELL R210 II from panic'ing. > Problem reported & tested by sthen@ > Much feedback & close review & OK by jsg@ (uebayasi@) ~ softraid.c > Avoid using uninitialized variables in two corner cases. In one > case check if it was set and bail out with a useful message if not. > In the other the variable was the wrong one anyway, and we can just > use the correct variable. > Found by & ok jsg@ (krw@) dev/hid ~ hidms.c > Permit negative x and y coordinates in mouse.scale for uts and ums. > Needed by some touchscreens. > no objection matthieu@ (guenther@) dev/ic ~ smc91cxx.c > pcakets -> packets (mmcc@) dev/pci ~ if_iwmreg.h > Make sure the maximum iwm(4) firmware command payload size fits into > the 12 bits available for it in struct iwm_tfd_tb.hi_n_len. > Patch by Imre Vadasz via tech@ (stsp@) ~ if_iwn.c > Fix off-by-one in loop termination condition. > ok stsp@ (tb@) ~ if_iwm.c > Make iwm(4) initialize net80211 callback pointers at attach time. > Fixes a crash reported by Donald Allen via misc@ > ok mpi@ (stsp@) dev/usb ~ uts.c > Permit negative x and y coordinates in mouse.scale for uts and ums. > Needed by some touchscreens. > no objection matthieu@ (guenther@) kern ~ subr_disk.c > "exceeds past the end" -> "extends past the end" in comment. (krw@) ~ kern_subr.c > Make sure uiomove does not copy more than uio_resid bytes, as the manual > says. Move code belonging to diagnostics in the #ifdef DIAGNOSTIC part > and add a KASSERT that makes sure that we do not run beyond uio_iov. > Diff from Martin Natano. (stefan@) net ~ if_vlan.c TAGGED OPENBSD_5_8 > There was another bug in vlan and carp ifih refcounting. An ifih > could be inserted twice into the the parent's list. Then the kernel > will panic if root does an ifconfig destroy of the parent interface. > This affects OpenBSD 5.8 only. > From markus@; OK mpi@ (bluhm@) ~ bpf.c TAGGED OPENBSD_5_8 > protect the bpf ring with splnet as well as the kernel lock. > kernel lock protects it against other cpus, but splnet prevents bpf > code running at splsoftnet (eg, like bridge does) from having the > rings trampled by a hardware interrupt on the same cpu. > ok mpi@ jmatthew@ (dlg@) ~ bpf.c TAGGED OPENBSD_5_8 > Convert to uiomove. From Martin Natano. (stefan@) net80211 ~ ieee80211_input.c > Hide some excessive net80211 debug printfs behind ieee80211_debug >= 2. > (stsp@) ~ ieee80211_input.c ~ ieee80211_node.h > Work around buggy APs which occasionally emit sequence numbers much higher > than the current 11n BlockAck window. The previous code would be fooled > into > moving the window forward and then drop packets until their sequence > numbers > catch up with the new window, which can take several minutes. > Fixes traffic stalls observed with Broadcom APs. > ok krw@ tb@ (stsp@) ~ ieee80211_input.c ~ ieee80211_node.h ~ ieee80211_proto.c > Stop requiring a BlockAck session timeout (again), and just use it if the > AP > is asking for it. This timeout should not be required anymore now that > krw@'s > hangs are fixed by working around APs which make sequence numbers jump > about. (stsp@) ~ ieee80211_input.c > Log frames which fall outside the BlockAack window in dmesg if the > interface debug flag is set (enabled with: ifconfig iwn0 debug). > Shows the frame's sequence number and the current BA window. > I'm adding this for diagnosis, just in case it will be needed to make > future decisions about tuning the heuristic which works around network > stalls caused by such frames. (stsp@) ~ ieee80211_input.c > Don't pass QoS "no data" frames to the A-MPDU reordering logic. Such frames > will cause major confusion since they don't carry a sequence number. > ok mpi@ sthen@ (stsp@) ~ ieee80211_input.c > In ieee80211_ba_input(), compute the expression '(sn - ba->ba_winend) & > 0xfff' > just once, by assigning its value to the 'count' variable earlier and > reusing > 'count' where this expression was used. > No functional change. This just results in better readability. (stsp@) ~ ieee80211_input.c > Trim text in comment. (stsp@) ~ ieee80211_input.c > Make the heuristic which catches frames with sequence numbers outside the > current BlockAck window compare against the actual window size, rather than > the maximum window size possible. As a result, two consecutive if-blocks > now check for the same condition, so merge them. (stsp@) ~ ieee80211_node.h > Fix whitespace. (stsp@) ~ ieee80211_input.c > In ieee80211_input(), initialize 'subtype' variable before using it. > Should have been part of the QoS "no data" fix. > ok tb@ (stsp@) ~ ieee80211_input.c > Remove superfluous assignments of 'subtype' in ieee80211_input(). > Suggested by sthen@ > ok tb@ (stsp@) netinet ~ ip_carp.c TAGGED OPENBSD_5_8 > Carp in OpenBSD 5.8 is affected by the same bug as vlan. By creating, > changing and destroying carp interfaces multiple times, root could > crash the OpenBSD 5.8 kernel with ifconfig. The reference counting > of carp_ifih in carp_set_ifp() was wrong, so a use after free was > possible. Reordering the operations fixes it. > From markus@; OK mpi@ (bluhm@) ~ ip_carp.c TAGGED OPENBSD_5_8 > There was another bug in vlan and carp ifih refcounting. An ifih > could be inserted twice into the the parent's list. Then the kernel > will panic if root does an ifconfig destroy of the parent interface. > This affects OpenBSD 5.8 only. > From markus@; OK mpi@ (bluhm@) ~ ip_output.c TAGGED OPENBSD_5_8 > Return ENOBUFS when bumping in the multicast max group memberships > This removes the only use of ETOOMANYREFS in our code, making intro(2) > match reality. No software out there explicitely checks for ETOOMANYREFS > in multicast code. > Discussed with millert@ and mpi@ (who suggested using ENOBUFS) (jca@) nfs ~ nfs_node.c > sync a function's comment with its signature > ok tedu@, with a slight tweak (mmcc@) ~ nfs_bio.c ~ nfs_subs.c ~ nfs_vnops.c > Convert to uiomove. From Martin Natano. (stefan@) ntfs ~ ntfs_subr.c > Convert to uiomove. While there, use size_t consistently for > variables 'left' and 'tocopy' and adapt printf and DPRINTF format > strings accordingly. > From Martin Natano. (stefan@) == usr.bin =========================================================== 10/11 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin doas ~ doas.c > require a tty for the password. > sudo regression noted by miod, fix by millert (tedu@) hexdump ~ hexdump.c > remove main() declaration > from Michal Mazurek (mmcc@) ~ display.c > Fix a bug that caused nothing to be skipped when skipping exactly the > number of bytes present in a regular file was requested. > Bug reported by a user called "tdm" on the comstyle #openbsd IRC channel. > Patch written by Michal Mazurek <akfaew at jasminek dot net>. > OK jung@ millert@ czarkoff@ (schwarze@) ~ display.c ~ hexdump.h ~ parse.c > For a long time, nomem() has been a wrapper for err(1, NULL) and > meanwhile emalloc() has turned into calloc() by doing malloc + memset. > Delete them and Use the libc functions directly instead. I've been > running with this diff for ages and was reminded of it by a similar > suggestion from mmcc@ and by recent diffs from Michal Mazurek. > ok mmcc@ (tb@) ~ parse.c > Replace a three step string duplication with strndup(). > ok and with input from tb@ (mmcc@) openssl ~ openssl.1 > sslv3 has been removed; > prompted by a mail from jiri navratil > help/ok sthen (jmc@) ~ openssl.1 > word fix from previous; ok sthen (jmc@) ssh ~ clientloop.c ~ kex.h ~ kex.c ~ opacket.h ~ packet.c ~ packet.h ~ serverloop.c > refactor activation of rekeying > This makes automatic rekeying internal to the packet code (previously > the server and client loops needed to assist). In doing to it makes > application of rekey limits more accurate by accounting for packets > about to be sent as well as packets queued during rekeying events > themselves. > Based on a patch from dtucker@ which was in turn based on a patch > Aleksander Adamowski in bz#2521; ok markus@ (djm@) ~ readconf.c > don't attempt to percent_expand() already-canonicalised addresses, > avoiding unnecessary failures when attempting to connect to scoped > IPv6 addresses (that naturally contain '%' characters) (djm@) ~ myproposal.h > turn off more old crypto in the client: hmac-md5, ripemd, truncated > HMACs, RC4, blowfish. ok markus@ dtucker@ (djm@) ~ sftp-client.c > fix regression in openssh-6.8 sftp client: existing destination > directories would incorrectly terminate recursive uploads; > bz#2528 (djm@) ~ ssh_config.5 ~ sshd_config.5 > sync crypto algorithm lists in ssh_config(5) and sshd_config(5) > with current reality. bz#2527 (djm@) ~ ssh-pkcs11.c > avoid fatal() for PKCS11 tokens that present empty key IDs > bz#1773, ok markus@ (djm@) tmux ~ cmd-run-shell.c > Expand client formats in run-shell. (nicm@) vi ~ docs/USD.doc/vi.man/vi.1 > avoid special characters; from michael reed (jmc@) ~ cl/cl_screen.c > Update comment: the #ifdef VDSUSP was removed in r1.22. (tim@) == usr.sbin ========================================================== 11/11 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.sbin dhcpd ~ memory.c > avoid a use after free when parsing address ranges from a config > ok krw@ (jsg@) ~ udpsock.c > sys/param.h -> sys/types.h. No need to drag in nitems() only to > use it once on an array declared iov[1]. Just use '1'. > ok yasuoka@ (krw@) dhcrelay ~ bpf.c ~ dhcpd.h ~ dhcrelay.c ~ dispatch.c ~ errwarn.c ~ packet.c > Eliminate #include inside *.h files and include only needed headers in > each *.c file. > Inspired by mention of header silliness by Edgar Pettijohn and mmcc@ > on tech@. (krw@) ftp-proxy ~ ftp-proxy.c > Exit early with an error if the "_ftp_proxy" user does not exist. This > prevents > rc.d waiting up to 30 secs when starting ftp-proxy right after updating > from 5.8 > because at that point sysmerge(8) would not have had a chance to run yet > and the > unpriv user would not exist. > issue reported by sthen@ > ok sthen@ benno@ jca@ (ajacoutot@) httpd ~ server_http.c > Include the server port number in the common and combined logs. This is > useful > to distinguish between http and https requests. > OK florian@ reyk@ a while ago (tim@) ~ server_http.c > Back out previous; requested by jung@ (tim@) ~ patterns.c > httpd patterns double free > issue and diff from Alexander Schrijver alex at flupzor nl > ok reyk@ (semarie@) ospf6d ~ ospf6d.conf.5 > ospf6d looks for net.inet6.ip6.forwarding, not net.inet.ip.forwarding. > OK jca@ jmc@ sthen@ claudio@ (reyk@) pkg_add ~ OpenBSD/PackageRepository.pm > drop privs prior to running ftp > okay sthen@ (espie@) ~ OpenBSD/PackageRepository.pm > tweak names > set LC_ALL everywhere since it's now easy (espie@) radiusd ~ radiusd.c > fix a use after free in an error path > ok yasuoka@ (jsg@) rtadvd ~ log.h ~ rtadvd.c > Mark a few others functions as __dead; ok bluhm@ (jca@) ~ dump.c > Print MAX addresses padded with a leading zero. (jca@) ~ config.c ~ rtadvd.c ~ rtadvd.h > typos (jca@) ~ config.c ~ config.h ~ dump.c ~ dump.h ~ if.c ~ if.h ~ rtadvd.c ~ rtadvd.h ~ timer.c ~ timer.h > Kill trailing whitespace. (jca@) ~ config.c ~ rtadvd.c ~ rtadvd.h > Kill code to send unicast packets which never got enabled. > and get rid of pointless memory allocations. > ok bluhm@ (jca@) ~ rtadvd.c > another typo (jca@) smtpd ~ control.c ~ smtpctl.c > rename variable sun to s_un to ease portability > diff from Freddy DISSAUX, ok gilles@, jung@, sunil@, millert@ (gilles@) ~ mproc.c > r1.16 accidentally masked retries on EAGAIN introduced in r1.15. > Fix and simplify imsg_read() return value checking into a single > if..else block. > Ok gilles@ jung@ (sunil@) ~ smtpd-api.h > add PROC_QUEUE_MESSAGE_UNCORRUPT to smtpd-api.h, needed by privsep queues > (gilles@) ~ makemap.c > when creating a db map, we use a temporary file to work on and atomically > move to destination when done. this causes dbopen() to be called with an > empty file which happens to... not work with other db libraries. > adding O_TRUNC is noop for us, fixes the issue for other libraries and > lets us reduce delta between us and portable. > ok sunil@, ok eric@ (gilles@) ~ mproc.c > Change imsg_read() return value checking from an if..else block to > a switch statement for improved readability. OK jung@ sunil@ gilles@ > (millert@) ~ makemap.c ~ smtpctl.c > Cleanup getopt(3) mis-use in sendmail compat code. > Avoid multiple getopt(3) evaluations without optreset set and > unspecified behavior of optind = 0 as per POSIX. Instead, iterate > over argv the first time for classification. Fixes -portable without > any divergence from -current, and all newaliases opts are handled > in one place. > Looks good to me millert@ > Ok gilles@ jung@ eric@ (sunil@) ~ makemap.8 ~ makemap.c > remove support for 'dbm' which is really 'recno' from our makemap, it can't > work because it requires dbopen() to be the call that creates the db, while > we want mkstemp() to create an empty db ourselves. > it has never worked, no one could ever create a recno db with our makemap & > no one actually noticed so drop it. > ok millert@, sunil@, jung@ (gilles@) ~ smtp.c > remove some noop leftover code from an earlier cleanup > diff from Peter Bisroev <[email protected]> (gilles@) ~ parse.y ~ smtp.c ~ smtpd.h > handle enqueuer socket as a regular listener that can be configured with > "listen on socket". this simplifies a bit of code, removes some special > cases and will allow attaching filters & masking source just as on lo0. > diff from Peter Bisroev <[email protected]> > ok gilles@, jung@ (gilles@) ~ smtpd.conf.5 > describe how 'listen on socket' works > original diff from Peter Bisroev <[email protected]> > rewording from me, linebreaks from jung@ (gilles@) ~ smtpd.conf.5 > tweak previous; (jmc@) ~ to.c > Simplify address parsing code by only using inet_net_pton(3). > There's no need to have a separate case for non-CIDR addresses using > inet_pton(3) as inet_net_pton(3) handles them as well. > This simplification is valid for all our daemons parsing addresses, > it is a common patern. > ok gilles@, millert@, jung@ (mpi@) tftp-proxy ~ tftp-proxy.c > Call daemon(3) later, to catch errors from getpwnam and others. > Also set up syslog logging earlier, so that error messages don't end on > stderr which has been closed by daemon(3). One additional s/errx/lerrx/ > for consistency. > Inspired by a proposal from ajacoutot@, ok ajacoutot@ sthen@ (jca@) tokeninit ~ tokeninit.c > hexidecimal -> hexadecimal (mmcc@) traceroute ~ traceroute.c > pledge for "dns" if -A is passed, even with -n. > The -A (Look up the AS number for each hop address) use DNS service. > ok jca@ sthen@ (semarie@) vmd ~ virtio.c > avoid a double free in an error path > ok stefan@ (jsg@) =============================================================================== _______________________________________________ owc mailing list [email protected] http://www.squish.net/mailman/listinfo/owc
