Re: [Owfs-developers] New release 2.9p4

Stefano Miccoli Thu, 01 May 2014 14:48:07 -0700

Thanks for including my suggestions in p4!

I found a small bug in the new antiloop code (module/owserver/src/c/owserver.c) please see the attached patch.

Stefano

diff --git a/module/owserver/src/c/owserver.c b/module/owserver/src/c/owserver.c
index 374f64a..0f08913 100644
--- a/module/owserver/src/c/owserver.c
+++ b/module/owserver/src/c/owserver.c
@@ -133,8 +133,7 @@ static void SetupAntiloop(int argc, char **argv)
        data_struct.rand = random() ;
        
        // command line arguments (don't clear out buffer)
-       for ( argnum=0 ; argnum < argc ; ++argc ) ;
-       {
+       for ( argnum=0 ; argnum < argc ; argnum++ ) {
                int argsize = strlen( argv[argnum] ) ;
                if ( argsize > left ) {
                        argsize = left ;

PS:

in my opinion, instead of the MD5 hash of some process data, a UUID <http://en.wikipedia.org/wiki/Universally_unique_identifier> would be more appropriate for the antiloop feature.

On 30 Apr 2014, at 02:35, Paul Alfille <[email protected]> wrote:

Release Notes owfs 2.9p4
4/30/2014

New features
1. Switch to git for source management
Still hosted on sourceforge.net
		git clone git://git.code.sf.net/p/owfs/code owfs-code
	cvs history brought over. 

2. Clean and test DS2409 (Microlan) hubs
	Addressing problem found by Ors Tiszay
	Works well with passive devices

	Problems with powered slaves, but probably not a software issue.
3. Improved and tested owserver protocol for server-to-server communication
	Use md5 hash for unique token

	Fixed byte counting issue in write messages
	Null-terminated string no longer required in path string

		(problem pointed out by Stefano Miccoli)
4. Added /system/configuration/version
	Reports owserver version
	Request from Stefano Miccoli



Fixes
1. Double initialization of mutex fixed
	Show stopper in FreeBSD
	Found by Johan Strom
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos. Get
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs_______________________________________________
Owfs-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/owfs-developers

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.  Get 
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs

_______________________________________________
Owfs-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/owfs-developers

Re: [Owfs-developers] New release 2.9p4

Reply via email to