On Friday 14 June 2013 08:06 Frank Karlitschek wrote: > Hi Robin, > > On 13.06.2013, at 16:11, Robin Appelman <icew...@owncloud.com> wrote: > > Currently the logic in lib/base.php and index.php haven't changed > > significantly for a long time, there have been some additions such as > > routing but the basic logic is simular as how it was years ago. > > Which is a good thing. ;-) > It's stable and working well. Unlike other areas of ownCloud.
Well, as Robin argues just below, it is *not* stable. It is fragile, unmaintainable, and practically untestable. > > This has the problem that that code in the way it's currently implemented > > is > > very hard to test automatically, difficult to maintain and extend. This > > leads to a situation where one of the most important parts of the code is > > a lot more vulnerable to bugs then it should be.[1] > > https://gist.github.com/icewind1991/5685072 > > > > The goal of the new system is to make a system that is testable, give apps > > better options of integrating into core, generally cleaning up some of the > > older systems currently in place and hopefully improve the overall quality > > of the product we deliver Your proposal looks like a solid base and a well-tested approach for building a pluggable server architecture. +1 > Let's talk about this at the developer meeting. As usual I'm sorry that I'm not able to attend, so I'll give my € 0.02 here instead. > I'm not so happy with another big restructuring that introduced new bugs. The restructuring is amongst others, to be able to catch bugs and regressions. As far as I can see little actual code has to be written, but the existing code has to be reordered/cleaned up, so we don't have to keep putting out fires because a patch has broken vital functionality. > Let's fokus on the areas that really need attention. Exactly ;) -- Med venlig hilsen / Best Regards Thomas Tanghus _______________________________________________ Owncloud mailing list Owncloud@kde.org https://mail.kde.org/mailman/listinfo/owncloud