-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello Boris,
Oyranos and ICC Examin changes are in git. Thanks for pointing out and the patch. Kai-Uwe Am 14.03.2014 18:25, schrieb Boris Samorodov: > 14.03.2014 20:28, Kai-Uwe Behrmann пишет: > >> I did only some static checking for compiling with clang. Thanks for then patch. It will be applied during next week. > > OK, great. > >> For the detection, it is not clear to me if ít means missing support in cmake for clang or if something like the clang-omp package would enable support for. >> OpenMP is used for paralellising colour conversions with lcms. > > There is no OpenMP at clang for now (clang 3.4). However Intel has > (and integrates) patches to clang to enable support. Hopefully > clang-3.5 release will have OpenMP support out of the box. > >> kind regards >> Kai-Uwe >> >> >> >> Boris Samorodov <b...@passap.ru> schrieb: >> Hi Kai-Uwe and All, >> >> I try to compile oyranos 0.9.5 at FreeBSD-10 with clang (default) >> compiler: >> ----- >> % uname -a >> FreeBSD srv.bb.tel.ru 10.0-RC3 FreeBSD 10.0-RC3 #1 r260036: Mon Dec 30 >> 03:21:53 SAMT 2013 b...@srv.bb.tel.ru:/usr/obj/usr/src/sys/GENERIC >> amd64 >> >> % clang -v >> FreeBSD clang version 3.3 (tags/RELEASE_33/final 183502) 20130610 >> Target: x86_64-unknown-freebsd10.0 >> Thread model: posix >> ----- >> >> While configure it's properly detected that OpenMP is missing: >> ----- >> Could NOT find OpenMP (missing: OpenMP_C_FLAGS OpenMP_CXX_FLAGS) >> ----- >> >> But while compiling an error occures: >> ----- >> [...] >> Linking CXX executable qcmsevents >> [ 94%] Built target qcmsevents >> Scanning dependencies of target image-display >> [ 94%] Building CXX object >> src/examples/CMakeFiles/image-display.dir/image_display/image_display.cpp.o >> In file included from >> /usr/ports/graphics/oyranos/work/oyranos-0.9.5/src/examples/image_display/image_display.cpp:201: >> /usr/ports/graphics/oyranos/work/oyranos-0.9.5/src/examples/image_display/../../liboyranos_core/oyranos_threads.c:184:9: >> error: use of undeclared identifier 'omp_get_num_procs' >> if((omp_get_num_procs() - 1) >= 1) >> ^ >> /usr/ports/graphics/oyranos/work/oyranos-0.9.5/src/examples/image_display/../../liboyranos_core/oyranos_threads.c:185:26: >> error: use of undeclared identifier 'omp_get_num_procs' >> oy_thread_count_ = omp_get_num_procs() - 1; >> ^ >> ----- >> >> Looking at the code (src/liboyranos_core/oyranos_threads.c) >> there is an unconditional inclusion of omp_get_num_procs(): >> ----- >> if((omp_get_num_procs() - 1) >= 1) >> oy_thread_count_ = omp_get_num_procs() - 1; >> else >> oy_thread_count_ = 1; >> ----- >> >> If first three lines are surrounded with an ifdef then oyranos >> compiles. >> The patch is: >> ----- >> --- src/liboyranos_core/oyranos_threads.c.orig 2014-03-13 >> 22:06:34.153920114 +0400 >> +++ src/liboyranos_core/oyranos_threads.c 2014-03-13 >> 22:07:12.182505283 +0400 >> @@ -181,9 +181,11 @@ >> oyObject_Lock( oy_job_message_list_->oy_, __func__, __LINE__ ); >> oyObject_UnLock( oy_job_message_list_->oy_, __func__, __LINE__ ); >> >> +#ifdef _OPENMP >> if((omp_get_num_procs() - 1) >= 1) >> oy_thread_count_ = omp_get_num_procs() - 1; >> else >> +#endif >> oy_thread_count_ = 1; >> >> oy_threads_ = >> (oyThread_t*)calloc(sizeof(oyThread_t),oy_thread_count_+1); >> ----- >> >> Is it the right thing to do? >> >> Thanks for your attention. > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJTJvDYAAoJEFH10hHregTIU2sH/iWFwTykjn0EhcHbDRvESjEM UwKGIozTPbkD8qf/OIQfMBel3cbDa0TOcaWHWVwUs2bW1fKFNt/lVT7xVwg+BkpV VY7+GG9gD0wEe91u+IpnudYW7YS+3Uqg3fcbWxu9WtILeBGZShM0IhSvsqql38rC 5tpEuJTm52wc076y9ny3DL6qqse1LzQsg2Qc1RUC/6JOmmKzvpktmY81e241Z5an FxCxY1MomQX7Su4gLtxsU2NmNW4DL4h3uFOk19p7TABK4c65HTmLm82YkAvlyEJ3 k20/FhW7WMPpN65sJm6xBa46aYm4+RnHQcKGCYbsZjEdy4vaxEaodLZ1bOvLjOE= =QxAW -----END PGP SIGNATURE----- ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Oyranos-devel mailing list Oyranos-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oyranos-devel
