I can live with the 80, but personally I vote for 2, to use a higher limit.
I find the code more readable when one statement is written to one line
only (In this case all the line breaks have clear semantic meaning).
I think 120-150 is a more natural fit for Java. Today we have better
monitor resolutions and most monitors can display 120-150 chars even in
the window is half of the desktop....
Marton
On 12/13/19 4:13 PM, anu engineer wrote:
Yes, +1 for 80 rule. Not sure what benefits it buys us by removing it
—Anu
On Dec 13, 2019, at 6:50 AM, Dinesh Chitlangia <[email protected]> wrote:
I would like to retain the current limit of 80 characters.
Increasing or decreasing will not really help as whatever problem of line
wrap you are facing today, you will face that even when the limit is 60 or
100 or 120.
So no matter what limit we set, there will always be reasons to not like
that limit.
That said, I would not like to remove the line length rule completely as it
help to make the code readable.
Thanks,
Dinesh
On Fri, Dec 13, 2019 at 3:37 AM Attila Doroszlai <[email protected]>
wrote:
Hi All,
I would like to start a discussion on whether we should change the
line length limit of 80 characters (enforced via Checkstyle) in Ozone.
I think it was a necessity in the Hadoop repo, but now that Ozone is
in its own repo, we no longer need to stick to 80 chars.
I would like to ask for your opinion if we should:
1. keep the current limit of 80 characters
2. impose a higher limit (please suggest value)
3. remove the line length rule completely
Thanks.
-Attila
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
