+1 Thanks Shashi
On Tue, Jan 7, 2020 at 10:33 AM Dinesh Chitlangia <[email protected]> wrote: > +1 > > Thanks, > Dinesh > > On Mon, Jan 6, 2020 at 4:08 PM yisheng lian <[email protected]> wrote: > > > Great idea +1 > > > > Thanks Attila for this suggestion. > > > > > > Anu Engineer <[email protected]> 於 2020年1月7日 週二 上午4:48寫道： > > > > > I think this is a great idea. Especially since it conserves the Ozone's > > > Github Action minutes. > > > > > > Thanks > > > Anu > > > > > > > > > On Mon, Jan 6, 2020 at 12:41 PM Attila Doroszlai < > [email protected]> > > > wrote: > > > > > > > Hi All, > > > > > > > > Ozone CI checks are run via Github Actions for both commits and PRs. > > > > They are even run in forks. This gives us the chance to get early > > > > feedback from CI before opening a PR by following these steps (only > > > > steps 2-3 are new): > > > > > > > > 1. push to branch in fork > > > > 2. wait for CI checks to complete > > > > 3. fix any errors > > > > 4. open PR > > > > > > > > In other words: please make sure to get a clean CI run in fork before > > > > opening PR. > > > > > > > > This has the following benefits: > > > > > > > > * minimize Github Actions resource usage from Ozone's quota > > > > ( > > > > > > > > > > https://help.github.com/en/actions/automating-your-workflow-with-github-actions/about-github-actions#usage-limits > > > > ) > > > > > > > > * improve reviewer bandwidth > > > > > > > > Please consider the suggestion, and follow this approach if you > agree. > > > > > > > > thanks, > > > > Attila > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: [email protected] > > > > For additional commands, e-mail: [email protected] > > > > > > > > > > > > > > > > > -- > > 連奕盛 > > [email protected] > > Phone:0901282616 > > >
