xiaoyuyao commented on a change in pull request #236: HDDS-2284.
XceiverClientMetrics should be initialised as part of XceiverClientManager
constructor.
URL: https://github.com/apache/hadoop-ozone/pull/236#discussion_r349302375
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##########
@@ -814,6 +814,11 @@ public void close() throws IOException {
IOUtils.cleanupWithLogger(LOG, xceiverClientManager);
}
+ @VisibleForTesting
+ public XceiverClientManager getXceiverClientManager() {
Review comment:
NIT: should we expose the XceiverClientMetris here instead of
XceiverClientManager in RpcClient? It can be consumed directly by the callers
(many of them are unit tests)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
