adoroszlai commented on a change in pull request #259: HDDS-2619. Fix Sonar
issues in ReconTaskControllerImpl.
URL: https://github.com/apache/hadoop-ozone/pull/259#discussion_r350410872
##########
File path:
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ReconTaskControllerImpl.java
##########
@@ -179,8 +186,8 @@ public void reInitializeTasks(OMMetadataManager
omMetadataManager)
List<Future<Pair>> results = executorService.invokeAll(tasks);
for (Future<Pair> f : results) {
String taskName = f.get().getLeft().toString();
- if (!(Boolean)f.get().getRight()) {
- LOG.info("Init failed for task : " + taskName);
+ if (!(boolean)f.get().getRight()) {
Review comment:
Although Sonar did not point it out: simply replacing `Pair` with
`Pair<String, Boolean>` would allow getting rid of the unsafe casts completely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
