adoroszlai commented on a change in pull request #282: HDDS-2646. Start
acceptance tests only if at least one THREE pipeline is available
URL: https://github.com/apache/hadoop-ozone/pull/282#discussion_r352093132
##########
File path: hadoop-ozone/dist/src/main/compose/ozone/docker-config
##########
@@ -25,6 +25,7 @@ OZONE-SITE.XML_ozone.scm.client.address=scm
OZONE-SITE.XML_ozone.replication=3
OZONE-SITE.XML_hdds.datanode.dir=/data/hdds
OZONE-SITE.XML_hdds.profiler.endpoint.enabled=true
+OZONE-SITE.XML_hdds.scm.safemode.min.datanode=3
Review comment:
This will make it impossible to use these environments with a single
datanode without modifying the config locally.
I would like to propose an alternative solution:
1. define this config in the `environment` section in `docker-compose.yaml`
using a variable that defaults to 1:
`-
"OZONE-SITE.XML_hdds.scm.safemode.min.datanode=${SAFEMODE_MIN_DATANODES:-1}"`
2. set the variable to 3 in `testlib.sh`:
`export SAFEMODE_MIN_DATANODES=3`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
