hanishakoneru commented on a change in pull request #276: HDDS-2637. Handle LeaderNot ready exception in OzoneManager StateMachine and upgrade ratis to latest version. URL: https://github.com/apache/hadoop-ozone/pull/276#discussion_r353387057
########## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java ########## @@ -370,13 +396,16 @@ private OMResponse submitRequest(OMRequest omRequest) return omResponse; } catch (ServiceException e) { -// throw ProtobufHelper.getRemoteException(e); NotLeaderException notLeaderException = getNotLeaderException(e); if (notLeaderException == null) { throw ProtobufHelper.getRemoteException(e); Review comment: Thats the intended behavior right? We check for NotLeaderException so as to update the error message to indicate why the failure occurred more accurately. For other scenarios, we want to throw the error to the client. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org